mirror of
				https://github.com/golang/go.git
				synced 2025-10-31 16:50:58 +00:00 
			
		
		
		
	 a32262d462
			
		
	
	
		a32262d462
		
	
	
	
	
		
			
			reflect.Type.Method (and MethodByName) can be used to obtain a reference of a method by reflection. The linker needs to know if reflect.Type.Method is called, and retain all exported methods accordingly. This is handled by the compiler, which marks the caller of reflect.Type.Method with REFLECTMETHOD attribute. The current code failed to handle the reflect package itself, so the method wrapper reflect.Type.Method is not marked. This CL fixes it. Fixes #38515. Change-Id: I12904d23eda664cf1794bc3676152f3218fb762b Reviewed-on: https://go-review.googlesource.com/c/go/+/228880 Run-TryBot: Cherry Zhang <cherryyz@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
		
			
				
	
	
		
			30 lines
		
	
	
	
		
			544 B
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			30 lines
		
	
	
	
		
			544 B
		
	
	
	
		
			Go
		
	
	
	
	
	
| // run
 | |
| 
 | |
| // Copyright 2020 The Go Authors. All rights reserved.
 | |
| // Use of this source code is governed by a BSD-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| // Issue 38515: failed to mark the method wrapper
 | |
| // reflect.Type.Method itself as REFLECTMETHOD.
 | |
| 
 | |
| package main
 | |
| 
 | |
| import "reflect"
 | |
| 
 | |
| var called bool
 | |
| 
 | |
| type foo struct{}
 | |
| 
 | |
| func (foo) X() { called = true }
 | |
| 
 | |
| var h = reflect.Type.Method
 | |
| 
 | |
| func main() {
 | |
| 	v := reflect.ValueOf(foo{})
 | |
| 	m := h(v.Type(), 0)
 | |
| 	f := m.Func.Interface().(func(foo))
 | |
| 	f(foo{})
 | |
| 	if !called {
 | |
| 		panic("FAIL")
 | |
| 	}
 | |
| }
 |