go/src
Austin Clements 548158c4a5 runtime: switch debuglog from const-toggled to type-toggled
Currently, the debuglog build tag controls the dlogEnabled const, and
all methods of dlogger first check this const and immediately return
if dlog is not enabled. With constant folding and inlining, this makes
the whole dlog implementation compile away if it's not enabled.

However, we want to be able to test debuglog even when the build tag
isn't set. For that to work, we need a different mechanism.

This CL changes this mechanism so the debuglog build tag instead
controls the type alias for dlogger to be either dloggerImpl or
dloggerFake. These two types have the same method set, but one is just
stubs. This way, the methods of dloggerImpl don't need to be
conditional dlogEnabled, which sets us up to use the now
fully-functional dloggerImpl type in the test.

I confirmed that this change has no effect on the final size of the
cmd/go binary. It does increase the size of the runtime.a file by 0.9%
and make the runtime take ever so slightly longer to compile because
the compiler can no longer simply eliminate the bodies of the all of
dlogger during early deadcode. However, this all gets eliminated by
the linker. I consider this worth it to always get build and test
coverage of debuglog.

Change-Id: I81759e9e1411b7d369a23383a18b022ab7451421
Reviewed-on: https://go-review.googlesource.com/c/go/+/600696
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-07-30 13:10:56 +00:00
..
archive archive: use slices and maps to clean up tests 2024-07-25 00:25:45 +00:00
arena arena: add experimental arena package 2022-10-12 20:23:36 +00:00
bufio bufio: allow terminating Scanner early cleanly without a final token or an error 2023-10-23 09:06:30 +00:00
builtin all: consistently use "IEEE 754" over "IEEE-754" 2024-04-11 20:22:45 +00:00
bytes bytes,strings,unicode/utf16: use slices to clean up tests 2024-07-24 18:45:08 +00:00
cmd cmd/internal/obj/loong64, cmd/asm: remove useless instructions 2024-07-30 00:34:48 +00:00
cmp cmd/compile: remove redundant calls to cmpstring 2024-04-19 16:31:02 +00:00
compress compress: reordering fields to reduce struct sizes 2024-04-26 13:32:40 +00:00
container container/heap: remove confusing claim of memory leak 2024-01-31 20:27:36 +00:00
context context: handle nil values for valueCtx.String() 2024-07-10 02:44:20 +00:00
crypto crypto/x509,embed: use slices to clean up tests 2024-07-24 16:44:15 +00:00
database/sql database/sql/driver: fix name in comment 2024-07-11 15:01:00 +00:00
debug debug/buildinfo: add test for malformed strings 2024-07-29 15:34:55 +00:00
embed crypto/x509,embed: use slices to clean up tests 2024-07-24 16:44:15 +00:00
encoding encoding/gob: fix package doc typo for wireType 2024-07-25 21:15:30 +00:00
errors errors: change interface{} to any in comment 2024-05-24 17:13:04 +00:00
expvar all: make use of sync.Map.Clear 2024-04-26 21:32:11 +00:00
flag flag: handle nil os.Args when setting CommandLine at package level 2024-07-22 20:58:27 +00:00
fmt all: change from sort functions to slices functions where feasible 2024-05-23 01:00:11 +00:00
go cmd: consolidate "known" os/arch tables into separate package 2024-07-29 15:38:20 +00:00
hash all: make function comments match function names 2024-06-03 14:56:25 +00:00
html html: update jstmpllitinterp doc 2024-05-22 18:04:29 +00:00
image all: make function comments match function names 2024-06-03 14:56:25 +00:00
index/suffixarray all: change from sort functions to slices functions where feasible 2024-05-23 01:00:11 +00:00
internal cmd: consolidate "known" os/arch tables into separate package 2024-07-29 15:38:20 +00:00
io go,internal,io,mime: use slices and maps to clean tests 2024-07-25 00:22:14 +00:00
iter iter: minor doc comment updates 2024-06-21 19:12:59 +00:00
log cmd,log,net,runtime: simplify string prefix and suffix processing 2024-07-29 21:29:17 +00:00
maps maps: document handling of non-reflexive keys 2024-07-17 23:08:52 +00:00
math math/big: fix comment typo in natdiv.go 2024-07-17 15:08:04 +00:00
mime go,internal,io,mime: use slices and maps to clean tests 2024-07-25 00:22:14 +00:00
net net/http: don't write HEAD response body in ResponseWriter.ReadFrom 2024-07-29 21:29:55 +00:00
os os: rm unused code 2024-07-27 00:57:42 +00:00
path os,path/filepath,testing: use slices to clean up tests 2024-07-25 00:23:06 +00:00
plugin plugin: add available godoc link 2023-11-06 19:46:10 +00:00
reflect cmd/compile, reflect: treat abi.NoEscape as cheap call 2024-07-26 16:18:47 +00:00
regexp regexp: allow patterns with no alternates to be one-pass 2024-07-24 01:01:48 +00:00
runtime runtime: switch debuglog from const-toggled to type-toggled 2024-07-30 13:10:56 +00:00
slices slices: explicitly document nil and empty slice equality 2024-07-22 17:38:46 +00:00
sort sort: add example for Find 2024-07-16 17:55:15 +00:00
strconv strconv: document that Unquote("''") returns an empty string 2024-07-22 18:35:09 +00:00
strings bytes,strings,unicode/utf16: use slices to clean up tests 2024-07-24 18:45:08 +00:00
structs cmd/compile: add structs.HostLayout 2024-05-20 21:19:39 +00:00
sync all: make struct comments match struct names 2024-07-11 17:23:45 +00:00
syscall syscall: selectively update zerrors_* on openbsd/386, openbsd/arm and openbsd/amd64 2024-06-16 23:08:08 +00:00
testdata
testing os,path/filepath,testing: use slices to clean up tests 2024-07-25 00:23:06 +00:00
text text/template: fix doc spacing 2024-07-22 20:58:50 +00:00
time time: fix time zone parsing when format includes time zone seconds 2024-07-02 20:01:50 +00:00
unicode bytes,strings,unicode/utf16: use slices to clean up tests 2024-07-24 18:45:08 +00:00
unique internal/concurrent: make HashTrieMap iteration more idiomatic 2024-05-22 16:01:55 +00:00
unsafe unsafe: say "functions like syscall.Syscall", not only Syscall 2024-07-11 23:38:31 +00:00
vendor all: update vendored dependencies 2024-07-23 20:29:12 +00:00
all.bash all.bash: allow spaces in $GOTOOLDIR to print build info 2024-03-11 19:53:58 +00:00
all.bat make.{bash,bat}: check unmodified $PATH for $GOROOT/bin presence 2023-04-19 14:36:22 +00:00
all.rc
bootstrap.bash cmd/dist: add map of broken ports and -force flag 2023-01-20 17:52:26 +00:00
buildall.bash src/buildall.bash: use grep -E instead of egrep 2024-04-23 17:45:23 +00:00
clean.bash
clean.bat
clean.rc
cmp.bash cmp.bash: fix comment grammar 2023-07-20 18:03:31 +00:00
go.mod all: update vendored dependencies 2024-07-23 20:29:12 +00:00
go.sum all: update vendored dependencies 2024-07-23 20:29:12 +00:00
make.bash make.bash: drop GNU/kFreeBSD handling 2024-07-22 21:24:34 +00:00
make.bat cmd: remove support for GOROOT_FINAL 2024-02-21 22:16:54 +00:00
Make.dist
make.rc make.bash: preserve GOROOT_BOOTSTRAP 2024-05-29 13:48:46 +00:00
race.bash
race.bat
README.vendor cmd: update vendored x/tools to 904c6ba 2024-04-02 02:20:05 +00:00
run.bash run.bash: rm bumping open files soft limit 2024-05-15 15:02:23 +00:00
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto', and if you use a go.work file, set GOWORK=off.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src  # or src/cmd
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.