mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
The old API was to do
r := obj.AddRel(sym)
r.Type = this
r.Off = that
etc
The new API is:
sym.AddRel(ctxt, obj.Reloc{Type: this: Off: that, etc})
This new API is more idiomatic and avoids ever having relocations
that are only partially constructed. Most importantly, it sets up
for sym.AddRel being able to check relocation validity in the future.
(Passing ctxt is for use in validity checking.)
Passes golang.org/x/tools/cmd/toolstash/buildall.
Change-Id: I042ea76e61bb3bf6402f98ca11291a13f4799972
Reviewed-on: https://go-review.googlesource.com/c/go/+/625616
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
136 lines
3.6 KiB
Go
136 lines
3.6 KiB
Go
// Copyright 2020 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package obj
|
|
|
|
import (
|
|
"bytes"
|
|
"internal/testenv"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
"unsafe"
|
|
|
|
"cmd/internal/goobj"
|
|
"cmd/internal/sys"
|
|
)
|
|
|
|
var dummyArch = LinkArch{Arch: sys.ArchAMD64}
|
|
|
|
func TestContentHash64(t *testing.T) {
|
|
s1 := &LSym{P: []byte("A")}
|
|
s2 := &LSym{P: []byte("A\x00\x00\x00")}
|
|
s1.Set(AttrContentAddressable, true)
|
|
s2.Set(AttrContentAddressable, true)
|
|
h1 := contentHash64(s1)
|
|
h2 := contentHash64(s2)
|
|
if h1 != h2 {
|
|
t.Errorf("contentHash64(s1)=%x, contentHash64(s2)=%x, expect equal", h1, h2)
|
|
}
|
|
|
|
ctxt := Linknew(&dummyArch) // little endian
|
|
s3 := ctxt.Int64Sym(int64('A'))
|
|
h3 := contentHash64(s3)
|
|
if h1 != h3 {
|
|
t.Errorf("contentHash64(s1)=%x, contentHash64(s3)=%x, expect equal", h1, h3)
|
|
}
|
|
}
|
|
|
|
func TestContentHash(t *testing.T) {
|
|
syms := []*LSym{
|
|
&LSym{P: []byte("TestSymbol")}, // 0
|
|
&LSym{P: []byte("TestSymbol")}, // 1
|
|
&LSym{P: []byte("TestSymbol2")}, // 2
|
|
&LSym{P: []byte("")}, // 3
|
|
&LSym{P: []byte("")}, // 4
|
|
&LSym{P: []byte("")}, // 5
|
|
&LSym{P: []byte("")}, // 6
|
|
}
|
|
for _, s := range syms {
|
|
s.Set(AttrContentAddressable, true)
|
|
s.PkgIdx = goobj.PkgIdxHashed
|
|
}
|
|
// s3 references s0
|
|
syms[3].R = []Reloc{{Sym: syms[0]}}
|
|
// s4 references s0
|
|
syms[4].R = []Reloc{{Sym: syms[0]}}
|
|
// s5 references s1
|
|
syms[5].R = []Reloc{{Sym: syms[1]}}
|
|
// s6 references s2
|
|
syms[6].R = []Reloc{{Sym: syms[2]}}
|
|
|
|
// compute hashes
|
|
h := make([]goobj.HashType, len(syms))
|
|
w := &writer{}
|
|
for i := range h {
|
|
h[i] = w.contentHash(syms[i])
|
|
}
|
|
|
|
tests := []struct {
|
|
a, b int
|
|
equal bool
|
|
}{
|
|
{0, 1, true}, // same contents, no relocs
|
|
{0, 2, false}, // different contents
|
|
{3, 4, true}, // same contents, same relocs
|
|
{3, 5, true}, // recursively same contents
|
|
{3, 6, false}, // same contents, different relocs
|
|
}
|
|
for _, test := range tests {
|
|
if (h[test.a] == h[test.b]) != test.equal {
|
|
eq := "equal"
|
|
if !test.equal {
|
|
eq = "not equal"
|
|
}
|
|
t.Errorf("h%d=%x, h%d=%x, expect %s", test.a, h[test.a], test.b, h[test.b], eq)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestSymbolTooLarge(t *testing.T) { // Issue 42054
|
|
testenv.MustHaveGoBuild(t)
|
|
if unsafe.Sizeof(uintptr(0)) < 8 {
|
|
t.Skip("skip on 32-bit architectures")
|
|
}
|
|
|
|
tmpdir := t.TempDir()
|
|
|
|
src := filepath.Join(tmpdir, "p.go")
|
|
err := os.WriteFile(src, []byte("package p; var x [1<<32]byte"), 0666)
|
|
if err != nil {
|
|
t.Fatalf("failed to write source file: %v\n", err)
|
|
}
|
|
obj := filepath.Join(tmpdir, "p.o")
|
|
cmd := testenv.Command(t, testenv.GoToolPath(t), "tool", "compile", "-p=p", "-o", obj, src)
|
|
out, err := cmd.CombinedOutput()
|
|
if err == nil {
|
|
t.Fatalf("did not fail\noutput: %s", out)
|
|
}
|
|
const want = "symbol too large"
|
|
if !bytes.Contains(out, []byte(want)) {
|
|
t.Errorf("unexpected error message: want: %q, got: %s", want, out)
|
|
}
|
|
}
|
|
|
|
func TestNoRefName(t *testing.T) {
|
|
// Test that the norefname flag works.
|
|
testenv.MustHaveGoBuild(t)
|
|
|
|
tmpdir := t.TempDir()
|
|
|
|
src := filepath.Join(tmpdir, "x.go")
|
|
err := os.WriteFile(src, []byte("package main; import \"fmt\"; func main() { fmt.Println(123) }\n"), 0666)
|
|
if err != nil {
|
|
t.Fatalf("failed to write source file: %v\n", err)
|
|
}
|
|
exe := filepath.Join(tmpdir, "x.exe")
|
|
|
|
// Build the fmt package with norefname. Not rebuilding all packages to save time.
|
|
// Also testing that norefname and non-norefname packages can link together.
|
|
cmd := testenv.Command(t, testenv.GoToolPath(t), "build", "-gcflags=fmt=-d=norefname", "-o", exe, src)
|
|
out, err := cmd.CombinedOutput()
|
|
if err != nil {
|
|
t.Fatalf("build failed: %v, output:\n%s", err, out)
|
|
}
|
|
}
|