mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
This CL implements this initial design of testing.B.Loop's keep variable alive semantic: https://github.com/golang/go/issues/61515#issuecomment-2407963248. Fixes #73137. Change-Id: I8060470dbcb0dda0819334f3615cc391ff0f6501 Reviewed-on: https://go-review.googlesource.com/c/go/+/716660 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com>
51 lines
2 KiB
Go
51 lines
2 KiB
Go
// errorcheck -0 -m
|
|
|
|
// Copyright 2025 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test keeping statements results in testing.B.Loop alive.
|
|
// See issue #61515, #73137.
|
|
|
|
package foo
|
|
|
|
import "testing"
|
|
|
|
func caninline(x int) int { // ERROR "can inline caninline"
|
|
return x
|
|
}
|
|
|
|
var something int
|
|
|
|
func caninlineNoRet(x int) { // ERROR "can inline caninlineNoRet"
|
|
something = x
|
|
}
|
|
|
|
func caninlineVariadic(x ...int) { // ERROR "can inline caninlineVariadic" "x does not escape"
|
|
something = x[0]
|
|
}
|
|
|
|
func test(b *testing.B, localsink, cond int) { // ERROR "leaking param: b"
|
|
for i := 0; i < b.N; i++ {
|
|
caninline(1) // ERROR "inlining call to caninline"
|
|
}
|
|
for b.Loop() { // ERROR "inlining call to testing\.\(\*B\)\.Loop"
|
|
caninline(1) // ERROR "inlining call to caninline" "function result will be kept alive" ".* does not escape"
|
|
caninlineNoRet(1) // ERROR "inlining call to caninlineNoRet" "function arg will be kept alive" ".* does not escape"
|
|
caninlineVariadic(1) // ERROR "inlining call to caninlineVariadic" "function arg will be kept alive" ".* does not escape"
|
|
caninlineVariadic(localsink) // ERROR "inlining call to caninlineVariadic" "localsink will be kept alive" ".* does not escape"
|
|
localsink = caninline(1) // ERROR "inlining call to caninline" "localsink will be kept alive" ".* does not escape"
|
|
localsink += 5 // ERROR "localsink will be kept alive" ".* does not escape"
|
|
localsink, cond = 1, 2 // ERROR "localsink will be kept alive" "cond will be kept alive" ".* does not escape"
|
|
if cond > 0 {
|
|
caninline(1) // ERROR "inlining call to caninline" "function result will be kept alive" ".* does not escape"
|
|
}
|
|
switch cond {
|
|
case 2:
|
|
caninline(1) // ERROR "inlining call to caninline" "function result will be kept alive" ".* does not escape"
|
|
}
|
|
{
|
|
caninline(1) // ERROR "inlining call to caninline" "function result will be kept alive" ".* does not escape"
|
|
}
|
|
}
|
|
}
|