a935749091
This change modifies this test (which involves an arbitrary timeout) to be a little less flaky by double-checking that our subprocess program completed even if the ticker fires and we've exceeded our timeout. The logic behind this change is that the testing goroutine might get delayed for any number of reasons, but the subprocess could still complete in time. Still, the goroutine will wake up to handle the ticker and see its over time, even though the event it was waiting for did actually happen. I can't reproduce #71548 locally, so I suspect because this test calls t.Parallel other load can delay the testing goroutine enough for this to happen (especially with GODEBUG=gccheckmark=1, which pauses everything to perform a full mark and sweep, and runtime tests love to call runtime.GC). For #71548. Change-Id: I83e86a0115f65950886b57b5af0b4a517ef5f90f Reviewed-on: https://go-review.googlesource.com/c/go/+/648576 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Auto-Submit: Michael Knyszek <mknyszek@google.com> Commit-Queue: Michael Knyszek <mknyszek@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| go.env | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.