mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
4dd77bdc91
The runtime traceback code has its own definition of which functions mark the top frame of a stack, separate from the TOPFRAME bits that exist in the assembly and are passed along in DWARF information. It's error-prone and redundant to have two different sources of truth. This CL provides the actual TOPFRAME bits to the runtime, so that the runtime can use those bits instead of reinventing its own category. This CL also adds a new bit, SPWRITE, which marks functions that write directly to SP (anything but adding and subtracting constants). Such functions must stop a traceback, because the traceback has no way to rederive the SP on entry. Again, the runtime has its own definition which is mostly correct, but also missing some functions. During ordinary goroutine context switches, such functions do not appear on the stack, so the incompleteness in the runtime usually doesn't matter. But profiling signals can arrive at any moment, and the runtime may crash during traceback if it attempts to unwind an SP-writing frame and gets out-of-sync with the actual stack. The runtime contains code to try to detect likely candidates but again it is incomplete. Deriving the SPWRITE bit automatically from the actual assembly code provides the complete truth, and passing it to the runtime lets the runtime use it. This CL is part of a stack adding windows/arm64 support (#36439), intended to land in the Go 1.17 cycle. This CL is, however, not windows/arm64-specific. It is cleanup meant to make the port (and future ports) easier. Change-Id: I227f53b23ac5b3dabfcc5e8ee3f00df4e113cf58 Reviewed-on: https://go-review.googlesource.com/c/go/+/288800 Trust: Russ Cox <rsc@golang.org> Trust: Jason A. Donenfeld <Jason@zx2c4.com> Reviewed-by: Cherry Zhang <cherryyz@google.com> Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com> |
||
|---|---|---|
| .. | ||
| abi | ||
| amd64 | ||
| arm | ||
| arm64 | ||
| base | ||
| bitvec | ||
| deadcode | ||
| devirtualize | ||
| dwarfgen | ||
| escape | ||
| gc | ||
| inline | ||
| ir | ||
| liveness | ||
| logopt | ||
| mips | ||
| mips64 | ||
| noder | ||
| objw | ||
| pkginit | ||
| ppc64 | ||
| reflectdata | ||
| riscv64 | ||
| s390x | ||
| ssa | ||
| ssagen | ||
| staticdata | ||
| staticinit | ||
| syntax | ||
| test | ||
| typebits | ||
| typecheck | ||
| types | ||
| walk | ||
| wasm | ||
| x86 | ||