mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
Separate patterns in asmcheck by spaces instead of commas. Many patterns end in comma (like "MOV [$]123,") so separating patterns by comma is not great; they're already quoted, so spaces are fine. Also replace all tabs in the assembly lines with spaces before matching. Finally, replace \$ or \\$ with [$] as the matching idiom. The effect of all these is to make the patterns look like: // amd64:"BSFQ" "ORQ [$]256" instead of the old: // amd64:"BSFQ","ORQ\t\\$256" Update all tests as well. Change-Id: Ia39febe5d7f67ba115846422789e11b185d5c807 Reviewed-on: https://go-review.googlesource.com/c/go/+/716060 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Alan Donovan <adonovan@google.com> Reviewed-by: Jorropo <jorropo.pgm@gmail.com>
44 lines
1.1 KiB
Go
44 lines
1.1 KiB
Go
// asmcheck
|
|
|
|
// Copyright 2018 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Make sure a pointer variable and a zero-sized variable
|
|
// aren't allocated to the same stack slot.
|
|
// See issue 24993.
|
|
|
|
package codegen
|
|
|
|
func zeroSize() {
|
|
c := make(chan struct{})
|
|
// amd64:`MOVQ \$0, command-line-arguments\.s\+56\(SP\)`
|
|
var s *int
|
|
// force s to be a stack object, also use some (fixed) stack space
|
|
g(&s, 1, 2, 3, 4, 5)
|
|
|
|
// amd64:`LEAQ command-line-arguments\..*\+55\(SP\)`
|
|
c <- noliteral(struct{}{})
|
|
}
|
|
|
|
// Like zeroSize, but without hiding the zero-sized struct.
|
|
func zeroSize2() {
|
|
c := make(chan struct{})
|
|
// amd64:`MOVQ \$0, command-line-arguments\.s\+48\(SP\)`
|
|
var s *int
|
|
// force s to be a stack object, also use some (fixed) stack space
|
|
g(&s, 1, 2, 3, 4, 5)
|
|
|
|
// amd64:`LEAQ command-line-arguments\..*stmp_\d+\(SB\)`
|
|
c <- struct{}{}
|
|
}
|
|
|
|
//go:noinline
|
|
func g(**int, int, int, int, int, int) {}
|
|
|
|
// noliteral prevents the compiler from recognizing a literal value.
|
|
//
|
|
//go:noinline
|
|
func noliteral[T any](t T) T {
|
|
return t
|
|
}
|