Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-07 13:50:04 +00:00
Code Issues Projects Releases Packages Wiki Activity
go/doc/next/6-stdlib/99-minor/crypto/rsa/74115.md
Filippo Valsorda ce39174482 crypto/rsa: check PrivateKey.D for consistency with Dp and Dq 
This unfortunately nearly doubles the runtime of
NewPrivateKeyWithPrecomputation. It would be nice to find an alternative
way to check it.

fips140: off
goos: darwin
goarch: arm64
pkg: crypto/rsa
cpu: Apple M2
                            │ 6aeb841faf  │             62ec3e34f3              │
                            │   sec/op    │    sec/op     vs base               │
ParsePKCS8PrivateKey/2048-8   70.28µ ± 0%   116.16µ ± 0%  +65.28% (p=0.002 n=6)

Fixes #74115

Change-Id: I6a6a6964091817d9aee359cc48932167e55184b9
Reviewed-on: https://go-review.googlesource.com/c/go/+/687836
Auto-Submit: Filippo Valsorda <filippo@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Daniel McCarney <daniel@binaryparadox.net>
Reviewed-by: Mark Freeman <markfreeman@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
2025-09-09 12:32:59 -07:00

204 B
Raw Blame History

If [PrivateKey] fields are modified after calling [PrivateKey.Precompute], [PrivateKey.Validate] now fails.

[PrivateKey.D] is now checked for consistency with precomputed values, even if it is not used.