mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
9e9ff565cd
This adds the support to enable the race detector for ppc64le. Added runtime/race_ppc64le.s to manage the calls from Go to the LLVM tsan functions, mostly converting from the Go ABI to the PPC64 ABI expected by Clang generated code. Changed racewalk.go to call racefuncenterfp instead of racefuncenter on ppc64le to allow the caller pc to be obtained in the asm code before calling the tsan version. Changed the set up code for racecallbackthunk so it doesn't use the autogenerated save and restore of the link register since that sequence uses registers inconsistent with the normal ppc64 ABI. Made various changes to recognize that race is supported for ppc64le. Ensured that tls_g is updated and accessible from race_linux_ppc64le.s so that the race ctx can be obtained and passed to tsan functions. This enables the race tests for ppc64le in cmd/dist/test.go and increases the timeout when running the benchmarks with the -race option to avoid timing out. Updates #24354, #23731 Change-Id: Ib97dc7ac313e6313c836dc7d2fb698f9d8fba3ef Reviewed-on: https://go-review.googlesource.com/107935 Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
81 lines
2.4 KiB
Go
81 lines
2.4 KiB
Go
// Copyright 2012 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package gc
|
|
|
|
import (
|
|
"cmd/compile/internal/types"
|
|
"cmd/internal/src"
|
|
"cmd/internal/sys"
|
|
)
|
|
|
|
// The racewalk pass is currently handled in two parts.
|
|
//
|
|
// First, for flag_race, it inserts calls to racefuncenter and
|
|
// racefuncexit at the start and end (respectively) of each
|
|
// function. This is handled below.
|
|
//
|
|
// Second, during buildssa, it inserts appropriate instrumentation
|
|
// calls immediately before each memory load or store. This is handled
|
|
// by the (*state).instrument method in ssa.go, so here we just set
|
|
// the Func.InstrumentBody flag as needed. For background on why this
|
|
// is done during SSA construction rather than a separate SSA pass,
|
|
// see issue #19054.
|
|
|
|
// TODO(dvyukov): do not instrument initialization as writes:
|
|
// a := make([]int, 10)
|
|
|
|
// Do not instrument the following packages at all,
|
|
// at best instrumentation would cause infinite recursion.
|
|
var omit_pkgs = []string{"runtime/internal/atomic", "runtime/internal/sys", "runtime", "runtime/race", "runtime/msan", "internal/cpu"}
|
|
|
|
// Only insert racefuncenterfp/racefuncexit into the following packages.
|
|
// Memory accesses in the packages are either uninteresting or will cause false positives.
|
|
var norace_inst_pkgs = []string{"sync", "sync/atomic"}
|
|
|
|
func ispkgin(pkgs []string) bool {
|
|
if myimportpath != "" {
|
|
for _, p := range pkgs {
|
|
if myimportpath == p {
|
|
return true
|
|
}
|
|
}
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
func instrument(fn *Node) {
|
|
if fn.Func.Pragma&Norace != 0 {
|
|
return
|
|
}
|
|
|
|
if !flag_race || !ispkgin(norace_inst_pkgs) {
|
|
fn.Func.SetInstrumentBody(true)
|
|
}
|
|
|
|
if flag_race {
|
|
lno := lineno
|
|
lineno = src.NoXPos
|
|
|
|
if thearch.LinkArch.Arch == sys.ArchPPC64LE {
|
|
fn.Func.Enter.Prepend(mkcall("racefuncenterfp", nil, nil))
|
|
fn.Func.Exit.Append(mkcall("racefuncexit", nil, nil))
|
|
} else {
|
|
|
|
// nodpc is the PC of the caller as extracted by
|
|
// getcallerpc. We use -widthptr(FP) for x86.
|
|
// BUG: This only works for amd64. This will not
|
|
// work on arm or others that might support
|
|
// race in the future.
|
|
nodpc := nodfp.copy()
|
|
nodpc.Type = types.Types[TUINTPTR]
|
|
nodpc.Xoffset = int64(-Widthptr)
|
|
fn.Func.Dcl = append(fn.Func.Dcl, nodpc)
|
|
fn.Func.Enter.Prepend(mkcall("racefuncenter", nil, nil, nodpc))
|
|
fn.Func.Exit.Append(mkcall("racefuncexit", nil, nil))
|
|
}
|
|
lineno = lno
|
|
}
|
|
}
|