mirror of
https://github.com/golang/go.git
synced 2025-12-08 06:10:04 +00:00
fb4f7fdb26
Currently, with PGO, the inliner uses node weights to decide if a function is inlineable (with a larger budget). But the actual inlining is determined by the weight of the call edge. There is a discrepancy that, if a callee node is hot but the call edge is not, it would not inlined, and marking the callee inlineable would of no use. Instead of using two kinds of weights, we just use the edge weights to decide inlineability. If a function is the callee of a hot call edge, its inlineability is determined with a larger threshold. For a function that exceeds the regular inlining budget, it is still inlined only when the call edge is hot, as it would exceed the regular inlining cost for non-hot call sites, even if it is marked inlineable. For #55022. Change-Id: I93fa9919fc6bcbb394e6cfe54ec96a96eede08f7 Reviewed-on: https://go-review.googlesource.com/c/go/+/447015 Run-TryBot: Cherry Mui <cherryyz@google.com> Reviewed-by: Michael Pratt <mpratt@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
59 lines
3.9 KiB
Go
59 lines
3.9 KiB
Go
// Copyright 2009 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Debug arguments, set by -d flag.
|
|
|
|
package base
|
|
|
|
// Debug holds the parsed debugging configuration values.
|
|
var Debug DebugFlags
|
|
|
|
// DebugFlags defines the debugging configuration values (see var Debug).
|
|
// Each struct field is a different value, named for the lower-case of the field name.
|
|
// Each field must be an int or string and must have a `help` struct tag.
|
|
//
|
|
// The -d option takes a comma-separated list of settings.
|
|
// Each setting is name=value; for ints, name is short for name=1.
|
|
type DebugFlags struct {
|
|
Append int `help:"print information about append compilation"`
|
|
Checkptr int `help:"instrument unsafe pointer conversions\n0: instrumentation disabled\n1: conversions involving unsafe.Pointer are instrumented\n2: conversions to unsafe.Pointer force heap allocation"`
|
|
Closure int `help:"print information about closure compilation"`
|
|
DclStack int `help:"run internal dclstack check"`
|
|
Defer int `help:"print information about defer compilation"`
|
|
DisableNil int `help:"disable nil checks"`
|
|
DumpPtrs int `help:"show Node pointers values in dump output"`
|
|
DwarfInl int `help:"print information about DWARF inlined function creation"`
|
|
Export int `help:"print export data"`
|
|
GCProg int `help:"print dump of GC programs"`
|
|
Gossahash string `help:"hash value for use in debugging the compiler"`
|
|
InlFuncsWithClosures int `help:"allow functions with closures to be inlined"`
|
|
Libfuzzer int `help:"enable coverage instrumentation for libfuzzer"`
|
|
LocationLists int `help:"print information about DWARF location list creation"`
|
|
Nil int `help:"print information about nil checks"`
|
|
NoOpenDefer int `help:"disable open-coded defers"`
|
|
NoRefName int `help:"do not include referenced symbol names in object file"`
|
|
PCTab string `help:"print named pc-value table\nOne of: pctospadj, pctofile, pctoline, pctoinline, pctopcdata"`
|
|
Panic int `help:"show all compiler panics"`
|
|
Reshape int `help:"print information about expression reshaping"`
|
|
Shapify int `help:"print information about shaping recursive types"`
|
|
Slice int `help:"print information about slice compilation"`
|
|
SoftFloat int `help:"force compiler to emit soft-float code"`
|
|
SyncFrames int `help:"how many writer stack frames to include at sync points in unified export data"`
|
|
TypeAssert int `help:"print information about type assertion inlining"`
|
|
TypecheckInl int `help:"eager typechecking of inline function bodies"`
|
|
Unified int `help:"enable unified IR construction"`
|
|
WB int `help:"print information about write barriers"`
|
|
ABIWrap int `help:"print information about ABI wrapper generation"`
|
|
MayMoreStack string `help:"call named function before all stack growth checks"`
|
|
InlineHotCallSiteThreshold string `help:"threshold percentage for determining call sites as hot candidates for inlining"`
|
|
InlineHotBudget int `help:"inline budget for hot functions"`
|
|
PGOInline int `help:"debug profile-guided inlining"`
|
|
|
|
ConcurrentOk bool // true if only concurrentOk flags seen
|
|
}
|
|
|
|
// DebugSSA is called to set a -d ssa/... option.
|
|
// If nil, those options are reported as invalid options.
|
|
// If DebugSSA returns a non-empty string, that text is reported as a compiler error.
|
|
var DebugSSA func(phase, flag string, val int, valString string) string
|