Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-10-23 18:03:35 +00:00
Code Issues Projects Releases Packages Wiki Activity

FileAccess: Don't err in store_buffer with buffer of size 0

Browse source 
The error check was added for `FileAccessUnix` but it's not an error when both
`p_src` and `p_length` are zero.

Added correct error checks to all implementations to prevent the actual
erroneous case: `p_src` is nullptr but `p_length > 0` (risk of null pointer
indexing).

Fixes #33564.
This commit is contained in:
Rémi Verschelde 2021-06-07 18:31:50 +02:00
parent 6f8d5cff66
commit 01d5c463be
No known key found for this signature in database
GPG key ID: C3336907360768E1
5 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/unix/file_access_unix.cpp
View file

@ -264,7 +264,7 @@ void FileAccessUnix::store_8(uint8_t p_dest) {
void FileAccessUnix::store_buffer(const uint8_t *p_src, uint64_t p_length) {
ERR_FAIL_COND_MSG(!f, "File must be opened before use.");
ERR_FAIL_COND(!p_src);
ERR_FAIL_COND(!p_src && p_length > 0);
ERR_FAIL_COND(fwrite(p_src, 1, p_length, f) != p_length);
}