Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-10-19 16:03:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #87952 from paulloz/dotnet/byebye-signal-callback-generation

Browse source 
Disable signal callback generation in C#
This commit is contained in:
Rémi Verschelde 2024-02-15 15:44:55 +01:00
commit 09df8f4a56
No known key found for this signature in database
GPG key ID: C3336907360768E1
10 changed files with 50 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

21
modules/mono/csharp_script.cpp
View file

@ -516,22 +516,11 @@ static String variant_type_to_managed_name(const String &p_var_type_name) {
}
String CSharpLanguage::make_function(const String &, const String &p_name, const PackedStringArray &p_args) const {
// FIXME
// - Due to Godot's API limitation this just appends the function to the end of the file
// - Use fully qualified name if there is ambiguity
String s = "private void " + p_name + "(";
for (int i = 0; i < p_args.size(); i++) {
const String &arg = p_args[i];
if (i > 0) {
s += ", ";
}
s += variant_type_to_managed_name(arg.get_slice(":", 1)) + " " + escape_csharp_keyword(arg.get_slice(":", 0));
}
s += ")\n{\n // Replace with function body.\n}\n";
return s;
// The make_function() API does not work for C# scripts.
// It will always append the generated function at the very end of the script. In C#, it will break compilation by
// appending code after the final closing bracket (either the class' or the namespace's).
// To prevent issues, we have can_make_function() returning false, and make_function() is never implemented.
return String();
}
#else
String CSharpLanguage::make_function(const String &, const String &, const PackedStringArray &) const {