Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-10-20 00:13:30 +00:00
Code Issues Projects Releases Packages Wiki Activity

fixes #76473, where filling a large amount of tiles all at once crashes

Browse source 
the engine due to segmentation fault.
This commit is contained in:
fuzzy@home 2023-04-28 22:00:24 +09:00
parent a83eb16fba
commit 09fa22002a
1 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
core/object/undo_redo.cpp
View file

@ -312,6 +312,11 @@ void UndoRedo::commit_action(bool p_execute) {
} }
void UndoRedo::_process_operation_list(List<Operation>::Element *E) { void UndoRedo::_process_operation_list(List<Operation>::Element *E) {
const int PREALLOCATE_ARGS_COUNT = 16;
LocalVector<const Variant *> args;
args.reserve(PREALLOCATE_ARGS_COUNT);
for (; E; E = E->next()) { for (; E; E = E->next()) {
Operation &op = E->get(); Operation &op = E->get();
@ -347,12 +352,13 @@ void UndoRedo::_process_operation_list(List<Operation>::Element *E) {
if (binds.is_empty()) { if (binds.is_empty()) {
method_callback(method_callback_ud, obj, op.name, nullptr, 0); method_callback(method_callback_ud, obj, op.name, nullptr, 0);
} else { } else {
const Variant **args = (const Variant **)alloca(sizeof(const Variant **) * binds.size()); args.clear();
for (int i = 0; i < binds.size(); i++) { for (int i = 0; i < binds.size(); i++) {
args[i] = (const Variant *)&binds[i]; args.push_back(&binds[i]);
} }
method_callback(method_callback_ud, obj, op.name, args, binds.size()); method_callback(method_callback_ud, obj, op.name, args.ptr(), binds.size());
} }
} }
} break; } break;