diff --git a/editor/import/3d/post_import_plugin_skeleton_renamer.cpp b/editor/import/3d/post_import_plugin_skeleton_renamer.cpp index 8db6215900c..938c924f292 100644 --- a/editor/import/3d/post_import_plugin_skeleton_renamer.cpp +++ b/editor/import/3d/post_import_plugin_skeleton_renamer.cpp @@ -187,15 +187,15 @@ void PostImportPluginSkeletonRenamer::internal_process(InternalImportCategory p_ // Main process of renaming bones. { // Apply pre-renaming result to prepared main rename map. - Vector remove_queue; - for (HashMap::Iterator E = main_rename_map.begin(); E; ++E) { - if (pre_rename_map.has(E->key)) { - remove_queue.push_back(E->key); + LocalVector remove_queue; + for (const KeyValue &kv : main_rename_map) { + if (pre_rename_map.has(kv.key)) { + remove_queue.push_back(kv.key); } } - for (int i = 0; i < remove_queue.size(); i++) { - main_rename_map.insert(pre_rename_map[remove_queue[i]], main_rename_map[remove_queue[i]]); - main_rename_map.erase(remove_queue[i]); + for (const String &key : remove_queue) { + main_rename_map.insert(pre_rename_map[key], main_rename_map[key]); + main_rename_map.erase(key); } _internal_process(p_category, p_base_scene, p_node, p_resource, p_options, main_rename_map); } diff --git a/scene/debugger/scene_debugger.cpp b/scene/debugger/scene_debugger.cpp index f37ef47511f..36ef16acac5 100644 --- a/scene/debugger/scene_debugger.cpp +++ b/scene/debugger/scene_debugger.cpp @@ -1292,11 +1292,9 @@ void LiveEditor::_remove_node_func(const NodePath &p_at) { return; //scene not editable } - Vector to_delete; - - for (HashSet::Iterator F = E->value.begin(); F; ++F) { - Node *n = *F; + LocalVector to_delete; + for (const Node *n : E->value) { if (base && !base->is_ancestor_of(n)) { continue; } @@ -1309,8 +1307,8 @@ void LiveEditor::_remove_node_func(const NodePath &p_at) { to_delete.push_back(n2); } - for (int i = 0; i < to_delete.size(); i++) { - memdelete(to_delete[i]); + for (Node *node : to_delete) { + memdelete(node); } } @@ -1330,10 +1328,8 @@ void LiveEditor::_remove_and_keep_node_func(const NodePath &p_at, ObjectID p_kee return; //scene not editable } - Vector to_remove; - for (HashSet::Iterator F = E->value.begin(); F; ++F) { - Node *n = *F; - + LocalVector to_remove; + for (Node *n : E->value) { if (base && !base->is_ancestor_of(n)) { continue; } @@ -1345,8 +1341,7 @@ void LiveEditor::_remove_and_keep_node_func(const NodePath &p_at, ObjectID p_kee to_remove.push_back(n); } - for (int i = 0; i < to_remove.size(); i++) { - Node *n = to_remove[i]; + for (Node *n : to_remove) { Node *n2 = n->get_node(p_at); n2->get_parent()->remove_child(n2); live_edit_remove_list[n][p_keep_id] = n2;