Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-07 22:00:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

Optimize String::chr to avoid calling strlen. Use String::chr instead of String(&chr, 1) where appropriate.

Browse source
This commit is contained in:
Lukas Tenbrink 2024-12-12 14:09:47 +01:00
parent 24d74510e5
commit 2aeca3e885
4 changed files with 8 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

6
core/variant/variant_setget.cpp
View file

@ -768,8 +768,7 @@ struct VariantIndexedSetGet_String {
*oob = true;
return;
}
char32_t result = (*VariantGetInternalPtr<String>::get_ptr(base))[index];
*value = String(&result, 1);
*value = String::chr((*VariantGetInternalPtr<String>::get_ptr(base))[index]);
*oob = false;
}
static void ptr_get(const void *base, int64_t index, void *member) {
@ -779,8 +778,7 @@ struct VariantIndexedSetGet_String {
index += v.length();
}
OOB_TEST(index, v.length());
char32_t c = v[index];
PtrToArg<String>::encode(String(&c, 1), member);
PtrToArg<String>::encode(String::chr(v[index]), member);
}
static void set(Variant *base, int64_t index, const Variant *value, bool *valid, bool *oob) {
if (value->get_type() != Variant::STRING) {