Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-10-19 16:03:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #101536 from xsellier/gdscript_crash_modulo

Browse source 
Fix crash when using a modulo operator between a float and an integer
This commit is contained in:
Thaddeus Crews 2025-07-01 17:57:48 -05:00
commit 2cf48a97b9
No known key found for this signature in database
GPG key ID: 8C6E5FEB5FC03CCC
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
modules/gdscript/gdscript_byte_codegen.cpp
View file

@ -588,7 +588,8 @@ void GDScriptByteCodeGenerator::write_binary_operator(const Address &p_target, V
if (valid && (p_operator == Variant::OP_DIVIDE || p_operator == Variant::OP_MODULE)) { if (valid && (p_operator == Variant::OP_DIVIDE || p_operator == Variant::OP_MODULE)) {
switch (p_left_operand.type.builtin_type) { switch (p_left_operand.type.builtin_type) {
case Variant::INT: case Variant::INT:
valid = p_right_operand.type.builtin_type != Variant::INT; // Cannot use modulo between int / float, we should raise an error later in GDScript
valid = p_right_operand.type.builtin_type != Variant::INT && p_operator == Variant::OP_DIVIDE;
break; break;
case Variant::VECTOR2I: case Variant::VECTOR2I:
case Variant::VECTOR3I: case Variant::VECTOR3I: