Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-10-19 07:53:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

Safe Camera::unproject_position()

Browse source 
`unproject_position()` can fail in some circumstances, and this needs to be conveyed to calling code.
This commit is contained in:
lawnjelly 2024-08-24 14:22:07 +01:00
parent 01c78d87fe
commit 31940c784a
3 changed files with 71 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

13
editor/spatial_editor_gizmos.cpp
View file

@ -586,7 +586,10 @@ bool EditorSpatialGizmo::intersect_ray(Camera *p_camera, const Point2 &p_point,
for (int i = 0; i < handles.size(); i++) {
Vector3 hpos = t.xform(handles[i]);
Vector2 p = p_camera->unproject_position(hpos);
Vector2 p;
if (!p_camera->safe_unproject_position(hpos, p)) {
continue;
}
if (p.distance_to(p_point) < HANDLE_HALF_SIZE) {
real_t dp = p_camera->get_transform().origin.distance_to(hpos);
@ -665,8 +668,12 @@ bool EditorSpatialGizmo::intersect_ray(Camera *p_camera, const Point2 &p_point,
Vector3 a = t.xform(vptr[i * 2 + 0]);
Vector3 b = t.xform(vptr[i * 2 + 1]);
Vector2 s[2];
s[0] = p_camera->unproject_position(a);
s[1] = p_camera->unproject_position(b);
if (!p_camera->safe_unproject_position(a, s[0])) {
continue;
}
if (!p_camera->safe_unproject_position(b, s[1])) {
continue;
}
Vector2 p = Geometry::get_closest_point_to_segment_2d(p_point, s);