From 047edb8933eaaf7b1aeedbe49990f61a5ef2cae1 Mon Sep 17 00:00:00 2001 From: Mike Precup Date: Thu, 10 Jul 2025 17:06:13 -0700 Subject: [PATCH] Avoid unnecessary copy in get_property_list --- core/object/class_db.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/core/object/class_db.cpp b/core/object/class_db.cpp index e8c82aae7af..b7080971e2f 100644 --- a/core/object/class_db.cpp +++ b/core/object/class_db.cpp @@ -1542,13 +1542,9 @@ void ClassDB::get_property_list(const StringName &p_class, List *p ClassInfo *check = type; while (check) { for (const PropertyInfo &pi : check->property_list) { + p_list->push_back(pi); if (p_validator) { - // Making a copy as we may modify it. - PropertyInfo pi_mut = pi; - p_validator->validate_property(pi_mut); - p_list->push_back(pi_mut); - } else { - p_list->push_back(pi); + p_validator->validate_property(p_list->back()->get()); } }