Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-10-24 18:33:36 +00:00
Code Issues Projects Releases Packages Wiki Activity

[HTML5] Fix HTTPClient request_raw.

Browse source 
Now send data according to the spec, properly handle null data.
Simplify JS code since we are at it.
This commit is contained in:
Fabio Alessandrelli 2021-02-11 09:32:17 +01:00
parent 9fb27eba8d
commit 4086a123b9
3 changed files with 19 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

15
platform/javascript/http_client_javascript.cpp
View file

@ -108,8 +108,12 @@ Error HTTPClient::request_raw(Method p_method, const String &p_url, const Vector
Error err = prepare_request(p_method, p_url, p_headers);
if (err != OK)
return err;
PoolByteArray::Read read = p_body.read();
godot_xhr_send_data(xhr_id, read.ptr(), p_body.size());
if (p_body.empty()) {
godot_xhr_send(xhr_id, nullptr, 0);
} else {
PoolByteArray::Read read = p_body.read();
godot_xhr_send(xhr_id, read.ptr(), p_body.size());
}
return OK;
}
@ -118,7 +122,12 @@ Error HTTPClient::request(Method p_method, const String &p_url, const Vector<Str
Error err = prepare_request(p_method, p_url, p_headers);
if (err != OK)
return err;
godot_xhr_send_string(xhr_id, p_body.utf8().get_data());
if (p_body.empty()) {
godot_xhr_send(xhr_id, nullptr, 0);
} else {
const CharString cs = p_body.utf8();
godot_xhr_send(xhr_id, cs.get_data(), cs.length());
}
return OK;
}