Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-07 13:49:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #113511 from dsnopek/required-param-not-really-required

Browse source 
Unmark `Node::is_editable_instance()` parameter as required
This commit is contained in:
Thaddeus Crews 2025-12-03 11:42:18 -06:00
commit 416491dcdd
No known key found for this signature in database
GPG key ID: 8C6E5FEB5FC03CCC
2 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
scene/main/node.cpp
View file

@ -2689,8 +2689,10 @@ void Node::set_editable_instance(RequiredParam<Node> rp_node, bool p_editable) {
p_node->_emit_editor_state_changed();
}
bool Node::is_editable_instance(RequiredParam<const Node> rp_node) const {
EXTRACT_PARAM_OR_FAIL_V(p_node, rp_node, false);
bool Node::is_editable_instance(const Node *p_node) const {
if (!p_node) {
return false; // Easier, null is never editable. :)
}
ERR_FAIL_COND_V(!is_ancestor_of(p_node), false);
return p_node->data.editable_instance;
}

2
scene/main/node.h
View file

@ -622,7 +622,7 @@ public:
String get_editor_description() const;
void set_editable_instance(RequiredParam<Node> rp_node, bool p_editable);
bool is_editable_instance(RequiredParam<const Node> rp_node) const;
bool is_editable_instance(const Node *p_node) const;
Node *get_deepest_editable_node(Node *p_start_node) const;
#ifdef TOOLS_ENABLED