mirror of
https://github.com/godotengine/godot.git
synced 2025-10-19 16:03:29 +00:00
Updated compiler version detection
This fixes multiple issues/inconsistencies around `get_compiler_version()`: * With no shell allocated, launching the compiler could fail even with proper paths being set. * The return value was described as "an array of version numbers as ints", but the function actually returned a `Dictionary` (or `None`). * Not all calls were properly handling a `None` return value in case of errors. On Windows this broke compiling for me since #81869 with default settings. * Some calls defined inconsistent defaults/fallbacks (`0` or `-1`).
This commit is contained in:
parent
fcbc50ec14
commit
426e18fd37
4 changed files with 31 additions and 21 deletions
35
methods.py
35
methods.py
|
@ -1002,19 +1002,32 @@ def is_vanilla_clang(env):
|
|||
|
||||
def get_compiler_version(env):
|
||||
"""
|
||||
Returns an array of version numbers as ints: [major, minor, patch].
|
||||
The return array should have at least two values (major, minor).
|
||||
Returns a dictionary with various version information:
|
||||
|
||||
- major, minor, patch: Version following semantic versioning system
|
||||
- metadata1, metadata2: Extra information
|
||||
- date: Date of the build
|
||||
"""
|
||||
ret = {
|
||||
"major": -1,
|
||||
"minor": -1,
|
||||
"patch": -1,
|
||||
"metadata1": None,
|
||||
"metadata2": None,
|
||||
"date": None,
|
||||
}
|
||||
|
||||
if not env.msvc:
|
||||
# Not using -dumpversion as some GCC distros only return major, and
|
||||
# Clang used to return hardcoded 4.2.1: # https://reviews.llvm.org/D56803
|
||||
try:
|
||||
version = subprocess.check_output([env.subst(env["CXX"]), "--version"]).strip().decode("utf-8")
|
||||
version = subprocess.check_output([env.subst(env["CXX"]), "--version"], shell=True).strip().decode("utf-8")
|
||||
except (subprocess.CalledProcessError, OSError):
|
||||
print("Couldn't parse CXX environment variable to infer compiler version.")
|
||||
return None
|
||||
else: # TODO: Implement for MSVC
|
||||
return None
|
||||
return ret
|
||||
else:
|
||||
# TODO: Implement for MSVC
|
||||
return ret
|
||||
match = re.search(
|
||||
r"(?:(?<=version )|(?<=\) )|(?<=^))"
|
||||
r"(?P<major>\d+)"
|
||||
|
@ -1026,9 +1039,13 @@ def get_compiler_version(env):
|
|||
version,
|
||||
)
|
||||
if match is not None:
|
||||
return match.groupdict()
|
||||
else:
|
||||
return None
|
||||
for key, value in match.groupdict().items():
|
||||
if value is not None:
|
||||
ret[key] = value
|
||||
# Transform semantic versioning to integers
|
||||
for key in ["major", "minor", "patch"]:
|
||||
ret[key] = int(ret[key] or -1)
|
||||
return ret
|
||||
|
||||
|
||||
def using_gcc(env):
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue