Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-10-31 21:51:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

Redo how instance bindings work

Browse source 
* The harcoded 8 slots are no more and impose limits in the new extension system.
* New system is limitless, although it will impose small performance hit with a mutex.
* Use a token to request the instance binding.

**Warning**: Mono will most likely break as a result of this, will need to be modified to use the new system.
This commit is contained in:
reduz 2021-07-08 16:16:02 -03:00
parent d4e5fe6c44
commit 4469144891
11 changed files with 111 additions and 62 deletions
Download patch file Download diff file Expand all files Collapse all files

13
modules/gdnative/nativescript/nativescript.cpp
View file

@ -1258,6 +1258,8 @@ void NativeScriptLanguage::unregister_binding_functions(int p_idx) {
}
void *NativeScriptLanguage::get_instance_binding_data(int p_idx, Object *p_object) {
return nullptr;
#if 0
ERR_FAIL_INDEX_V(p_idx, binding_functions.size(), nullptr);
ERR_FAIL_COND_V_MSG(!binding_functions[p_idx].first, nullptr, "Tried to get binding data for a nativescript binding that does not exist.");
@ -1287,9 +1289,12 @@ void *NativeScriptLanguage::get_instance_binding_data(int p_idx, Object *p_objec
}
return (*binding_data)[p_idx];
#endif
}
void *NativeScriptLanguage::alloc_instance_binding_data(Object *p_object) {
return nullptr;
#if 0
Vector<void *> *binding_data = new Vector<void *>;
binding_data->resize(binding_functions.size());
@ -1301,9 +1306,11 @@ void *NativeScriptLanguage::alloc_instance_binding_data(Object *p_object) {
binding_instances.insert(binding_data);
return (void *)binding_data;
#endif
}
void NativeScriptLanguage::free_instance_binding_data(void *p_data) {
#if 0
if (!p_data) {
return;
}
@ -1323,9 +1330,11 @@ void NativeScriptLanguage::free_instance_binding_data(void *p_data) {
binding_instances.erase(&binding_data);
delete &binding_data;
#endif
}
void NativeScriptLanguage::refcount_incremented_instance_binding(Object *p_object) {
#if 0
void *data = p_object->get_script_instance_binding(lang_idx);
if (!data) {
@ -1347,9 +1356,11 @@ void NativeScriptLanguage::refcount_incremented_instance_binding(Object *p_objec
binding_functions[i].second.refcount_incremented_instance_binding(binding_data[i], p_object);
}
}
#endif
}
bool NativeScriptLanguage::refcount_decremented_instance_binding(Object *p_object) {
#if 0
void *data = p_object->get_script_instance_binding(lang_idx);
if (!data) {
@ -1375,6 +1386,8 @@ bool NativeScriptLanguage::refcount_decremented_instance_binding(Object *p_objec
}
return can_die;
#endif
return false;
}
void NativeScriptLanguage::set_global_type_tag(int p_idx, StringName p_class_name, const void *p_type_tag) {