Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-10-19 16:03:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

[macOS] Fix infinite loop caused by global menu callbacks which trigger EditorProgress dialog.

Browse source 
(cherry picked from commit 48730e3b77)
This commit is contained in:
bruvzg 2023-03-23 13:26:11 +02:00 • committed by Rémi Verschelde
parent c9ee508089
commit 50f26811b0
No known key found for this signature in database
GPG key ID: C3336907360768E1
2 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
platform/macos/display_server_macos.h
View file

@ -188,7 +188,7 @@ private:
Variant tag;
Callable callback;
};
Vector<MenuCall> deferred_menu_calls;
List<MenuCall> deferred_menu_calls;
const NSMenu *_get_menu_root(const String &p_menu_root) const;
NSMenu *_get_menu_root(const String &p_menu_root);

10
platform/macos/display_server_macos.mm
View file

@ -3491,14 +3491,16 @@ void DisplayServerMacOS::process_events() {
}
// Process "menu_callback"s.
for (MenuCall &E : deferred_menu_calls) {
Variant tag = E.tag;
while (List<MenuCall>::Element *call_p = deferred_menu_calls.front()) {
MenuCall call = call_p->get();
deferred_menu_calls.pop_front(); // Remove before call to avoid infinite loop in case callback is using `process_events` (e.g. EditorProgress).
Variant tag = call.tag;
Variant *tagp = &tag;
Variant ret;
Callable::CallError ce;
E.callback.callp((const Variant **)&tagp, 1, ret, ce);
call.callback.callp((const Variant **)&tagp, 1, ret, ce);
}
deferred_menu_calls.clear();
if (!drop_events) {
_process_key_events();