Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-08 06:09:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

Adjust LOD selection metrics to use attribute error

Browse source 
- Revert meshoptimizer patch; the metric used for LOD selection now
incorporates attribute error
- Since LOD selection is now aware of attribute deviation, we don't
need to use a higher normal weight
- To prevent normal creases from creating input triangles with very
large normal deviation, reduce default normal merge threshold
- Since we now use combined metric to select LODs, we never need LODs
with error>1 as these should not be selected if the mesh is visible.
This commit is contained in:
Arseny Kapoulkine 2025-05-18 17:38:54 +03:00
parent c3ae6aa10b
commit 6190d412d3
4 changed files with 6 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

6
scene/resources/3d/importer_mesh.cpp
View file

@ -443,8 +443,8 @@ void ImporterMesh::generate_lods(float p_normal_merge_angle, Array p_bone_transf
float attrib_weights[attrib_count] = {};
// Give more weight to normal preservation
attrib_weights[0] = attrib_weights[1] = attrib_weights[2] = 2.0f;
// Give some weight to normal preservation
attrib_weights[0] = attrib_weights[1] = attrib_weights[2] = 1.0f;
// Give some weight to colors but only if present to avoid redundant computations during simplification
if (colors_ptr) {
@ -474,7 +474,7 @@ void ImporterMesh::generate_lods(float p_normal_merge_angle, Array p_bone_transf
unsigned int index_target = 12; // Start with the smallest target, 4 triangles
unsigned int last_index_count = 0;
const float max_mesh_error = FLT_MAX; // We don't want to limit by error, just by index target
const float max_mesh_error = 1.0f; // we only need LODs that can be selected by error threshold
float mesh_error = 0.0f;
while (index_target < index_count) {