Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-10-19 16:03:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix incorrect mipmap size calculation for uncompressed DDS textures

Browse source 
Previously, the DDS texture loader incorrectly calculated mipmap dimensions
for uncompressed textures when the original dimensions
were non-power-of-two.

For example, given a 120×120 texture, the expected mipmap chain should be:
    mipmap=0, size=120×120
    mipmap=1, size=60×60
    mipmap=2, size=30×30
    mipmap=3, size=15×15
    mipmap=4, size=7×7
    mipmap=5, size=3×3
    mipmap=6, size=1×1

But the loader was producing:
    mipmap=0, size=120×120
    mipmap=1, size=60×60
    mipmap=2, size=30×30
    mipmap=3, size=15×15
    mipmap=4, size=8×8
    mipmap=5, size=4×4
    mipmap=6, size=2×2

This commit corrects the logic to properly compute width and height independently at each mip level.

Fixes issue #105136.
This commit is contained in:
Oleksandr Shyshatskyi 2025-04-09 18:40:20 +03:00
parent 4248411baf
commit 65c9f44a2f
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
modules/dds/texture_loader_dds.cpp
View file

@ -165,8 +165,8 @@ static Ref<Image> _dds_load_layer(Ref<FileAccess> p_file, DDSFormat p_dds_format
uint32_t size = p_width * p_height * info.block_size; uint32_t size = p_width * p_height * info.block_size;
for (uint32_t i = 1; i < p_mipmaps; i++) { for (uint32_t i = 1; i < p_mipmaps; i++) {
w = (w + 1) >> 1; w = MAX(1u, w >> 1);
h = (h + 1) >> 1; h = MAX(1u, h >> 1);
size += w * h * info.block_size; size += w * h * info.block_size;
} }