Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-10-20 00:13:30 +00:00
Code Issues Projects Releases Packages Wiki Activity

GDScript: Add CONFUSABLE_CAPTURE_REASSIGNMENT warning

Browse source
This commit is contained in:
Danil Alexeev 2024-06-28 09:35:04 +03:00
parent cae2f853dc
commit 68898dbcc9
No known key found for this signature in database
GPG key ID: 124453E157DA8DC7
7 changed files with 88 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

15
modules/gdscript/gdscript_analyzer.cpp
View file

@ -2663,6 +2663,21 @@ void GDScriptAnalyzer::reduce_assignment(GDScriptParser::AssignmentNode *p_assig
reduce_expression(p_assignment->assignee);
#ifdef DEBUG_ENABLED
{
GDScriptParser::ExpressionNode *base = p_assignment->assignee;
while (base && base->type == GDScriptParser::Node::SUBSCRIPT) {
base = static_cast<GDScriptParser::SubscriptNode *>(base)->base;
}
if (base && base->type == GDScriptParser::Node::IDENTIFIER) {
GDScriptParser::IdentifierNode *id = static_cast<GDScriptParser::IdentifierNode *>(base);
if (current_lambda && current_lambda->captures_indices.has(id->name)) {
parser->push_warning(p_assignment, GDScriptWarning::CONFUSABLE_CAPTURE_REASSIGNMENT, id->name);
}
}
}
#endif
if (p_assignment->assigned_value == nullptr || p_assignment->assignee == nullptr) {
return;
}