Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-07 22:00:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #110748 from MauriceButler/project-setting-changed-signal

Browse source 
Add ability to get list of Project Settings changed, similar to Editor Settings functionality
This commit is contained in:
Thaddeus Crews 2025-11-07 10:32:39 -06:00
commit 6fd949a6dc
No known key found for this signature in database
GPG key ID: 8C6E5FEB5FC03CCC
4 changed files with 141 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

76
tests/core/config/test_project_settings.h
View file

@ -155,4 +155,80 @@ TEST_CASE("[ProjectSettings] localize_path") {
TestProjectSettingsInternalsAccessor::resource_path() = old_resource_path;
}
TEST_CASE("[SceneTree][ProjectSettings] settings_changed signal") {
SIGNAL_WATCH(ProjectSettings::get_singleton(), SNAME("settings_changed"));
ProjectSettings::get_singleton()->set_setting("test_signal_setting", "test_value");
MessageQueue::get_singleton()->flush();
SIGNAL_CHECK("settings_changed", { {} });
SIGNAL_UNWATCH(ProjectSettings::get_singleton(), SNAME("settings_changed"));
}
TEST_CASE("[ProjectSettings] get_changed_settings basic functionality") {
String setting_name = "test_changed_setting";
ProjectSettings::get_singleton()->set_setting(setting_name, "test_value");
PackedStringArray changes = ProjectSettings::get_singleton()->get_changed_settings();
CHECK(changes.has(setting_name));
}
TEST_CASE("[ProjectSettings] get_changed_settings multiple settings") {
ProjectSettings::get_singleton()->set_setting("test_setting_1", "value1");
ProjectSettings::get_singleton()->set_setting("test_setting_2", "value2");
ProjectSettings::get_singleton()->set_setting("another_group/setting", "value3");
PackedStringArray changes = ProjectSettings::get_singleton()->get_changed_settings();
CHECK(changes.has("test_setting_1"));
CHECK(changes.has("test_setting_2"));
CHECK(changes.has("another_group/setting"));
}
TEST_CASE("[ProjectSettings] check_changed_settings_in_group") {
ProjectSettings::get_singleton()->set_setting("group1/setting1", "value1");
ProjectSettings::get_singleton()->set_setting("group1/setting2", "value2");
ProjectSettings::get_singleton()->set_setting("group2/setting1", "value3");
ProjectSettings::get_singleton()->set_setting("other_setting", "value4");
CHECK(ProjectSettings::get_singleton()->check_changed_settings_in_group("group1/"));
CHECK(ProjectSettings::get_singleton()->check_changed_settings_in_group("group2/"));
CHECK_FALSE(ProjectSettings::get_singleton()->check_changed_settings_in_group("nonexistent/"));
CHECK(ProjectSettings::get_singleton()->check_changed_settings_in_group("group1"));
CHECK(ProjectSettings::get_singleton()->check_changed_settings_in_group("other_setting"));
}
TEST_CASE("[SceneTree][ProjectSettings] Changes cleared after settings_changed signal") {
SIGNAL_WATCH(ProjectSettings::get_singleton(), SNAME("settings_changed"));
ProjectSettings::get_singleton()->set_setting("signal_clear_test", "value");
PackedStringArray changes_before = ProjectSettings::get_singleton()->get_changed_settings();
CHECK(changes_before.has("signal_clear_test"));
MessageQueue::get_singleton()->flush();
SIGNAL_CHECK("settings_changed", { {} });
PackedStringArray changes_after = ProjectSettings::get_singleton()->get_changed_settings();
CHECK_FALSE(changes_after.has("signal_clear_test"));
SIGNAL_UNWATCH(ProjectSettings::get_singleton(), SNAME("settings_changed"));
}
TEST_CASE("[ProjectSettings] No tracking when setting same value") {
String setting_name = "same_value_test";
String test_value = "same_value";
ProjectSettings::get_singleton()->set_setting(setting_name, test_value);
int count_before = ProjectSettings::get_singleton()->get_changed_settings().size();
// Setting the same value should not be tracked due to early return.
ProjectSettings::get_singleton()->set_setting(setting_name, test_value);
int count_after = ProjectSettings::get_singleton()->get_changed_settings().size();
CHECK_EQ(count_before, count_after);
}
} // namespace TestProjectSettings