Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-10-19 16:03:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #72794 from vnen/gdscript-no-onready-without-node

Browse source 
GDScript: Don't allow @onready without inheriting Node
This commit is contained in:
Rémi Verschelde 2023-02-06 15:41:02 +01:00
commit 8a37fad281
No known key found for this signature in database
GPG key ID: C3336907360768E1
5 changed files with 19 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
modules/gdscript/gdscript_parser.cpp
View file

@ -3611,6 +3611,10 @@ bool GDScriptParser::icon_annotation(const AnnotationNode *p_annotation, Node *p
bool GDScriptParser::onready_annotation(const AnnotationNode *p_annotation, Node *p_node) {
ERR_FAIL_COND_V_MSG(p_node->type != Node::VARIABLE, false, R"("@onready" annotation can only be applied to class variables.)");
if (head && !ClassDB::is_parent_class(head->get_datatype().native_type, SNAME("Node"))) {
push_error(R"("@onready" can only be used in classes that inherit "Node".)", p_annotation);
}
VariableNode *variable = static_cast<VariableNode *>(p_node);
if (variable->onready) {
push_error(R"("@onready" annotation can only be used once per variable.)");