Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-07 13:49:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #113573 from MattiaZir/fix-color-picker-crash

Browse source 
Fix memory management for ColorPalette in save file dialog
This commit is contained in:
Rémi Verschelde 2025-12-05 09:38:21 +01:00
commit 8bff45aa36
No known key found for this signature in database
GPG key ID: C3336907360768E1
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
scene/gui/color_picker.cpp
View file

@ -974,7 +974,8 @@ void ColorPicker::_palette_file_selected(const String &p_path) {
#endif #endif
} break; } break;
case FileDialog::FileMode::FILE_MODE_SAVE_FILE: { case FileDialog::FileMode::FILE_MODE_SAVE_FILE: {
ColorPalette *palette = memnew(ColorPalette); Ref<ColorPalette> palette;
palette.instantiate();
palette->set_colors(get_presets()); palette->set_colors(get_presets());
Error error = ResourceSaver::save(palette, p_path); Error error = ResourceSaver::save(palette, p_path);
ERR_FAIL_COND_MSG(error != Error::OK, vformat("Cannot open color palette file for writing at: %s", p_path)); ERR_FAIL_COND_MSG(error != Error::OK, vformat("Cannot open color palette file for writing at: %s", p_path));