Add -Wshadow=local to warnings and fix reported issues.

Fixes #25316.
This commit is contained in:
marxin 2019-02-12 21:10:08 +01:00 committed by Rémi Verschelde
parent 132e2f458d
commit 8d51618949
134 changed files with 1107 additions and 1110 deletions

View file

@ -679,10 +679,10 @@ VisualScriptExpression::ENode *VisualScriptExpression::_parse_expression() {
}
str_ofs = cofs; //revert
//parse an expression
ENode *expr = _parse_expression();
if (!expr)
ENode *expr2 = _parse_expression();
if (!expr2)
return NULL;
dn->dict.push_back(expr);
dn->dict.push_back(expr2);
_get_token(tk);
if (tk.type != TK_COLON) {
@ -690,11 +690,11 @@ VisualScriptExpression::ENode *VisualScriptExpression::_parse_expression() {
return NULL;
}
expr = _parse_expression();
if (!expr)
expr2 = _parse_expression();
if (!expr2)
return NULL;
dn->dict.push_back(expr);
dn->dict.push_back(expr2);
cofs = str_ofs;
_get_token(tk);
@ -723,10 +723,10 @@ VisualScriptExpression::ENode *VisualScriptExpression::_parse_expression() {
}
str_ofs = cofs; //revert
//parse an expression
ENode *expr = _parse_expression();
if (!expr)
ENode *expr2 = _parse_expression();
if (!expr2)
return NULL;
an->array.push_back(expr);
an->array.push_back(expr2);
cofs = str_ofs;
_get_token(tk);
@ -807,11 +807,11 @@ VisualScriptExpression::ENode *VisualScriptExpression::_parse_expression() {
}
str_ofs = cofs; //revert
//parse an expression
ENode *expr = _parse_expression();
if (!expr)
ENode *expr2 = _parse_expression();
if (!expr2)
return NULL;
constructor->arguments.push_back(expr);
constructor->arguments.push_back(expr2);
cofs = str_ofs;
_get_token(tk);
@ -848,11 +848,11 @@ VisualScriptExpression::ENode *VisualScriptExpression::_parse_expression() {
}
str_ofs = cofs; //revert
//parse an expression
ENode *expr = _parse_expression();
if (!expr)
ENode *expr2 = _parse_expression();
if (!expr2)
return NULL;
bifunc->arguments.push_back(expr);
bifunc->arguments.push_back(expr2);
cofs = str_ofs;
_get_token(tk);
@ -947,25 +947,25 @@ VisualScriptExpression::ENode *VisualScriptExpression::_parse_expression() {
while (true) {
int cofs = str_ofs;
int cofs3 = str_ofs;
_get_token(tk);
if (tk.type == TK_PARENTHESIS_CLOSE) {
break;
}
str_ofs = cofs; //revert
str_ofs = cofs3; //revert
//parse an expression
ENode *expr = _parse_expression();
if (!expr)
ENode *expr2 = _parse_expression();
if (!expr2)
return NULL;
func_call->arguments.push_back(expr);
func_call->arguments.push_back(expr2);
cofs = str_ofs;
cofs3 = str_ofs;
_get_token(tk);
if (tk.type == TK_COMMA) {
//all good
} else if (tk.type == TK_PARENTHESIS_CLOSE) {
str_ofs = cofs;
str_ofs = cofs3;
} else {
_set_error("Expected ',' or ')'");
}
@ -1426,8 +1426,8 @@ public:
for (int i = 0; i < call->arguments.size(); i++) {
Variant value;
bool ret = _execute(p_inputs, call->arguments[i], value, r_error_str, ce);
if (ret)
bool ret2 = _execute(p_inputs, call->arguments[i], value, r_error_str, ce);
if (ret2)
return true;
arr.write[i] = value;
argp.write[i] = &arr[i];