Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-08 06:09:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

Avoid single character String allocations when appending characters

Browse source 
Removed calls to String::chr() when appending characters to Strings in Expression, Resource, and VariantParser, to avoid creating temporary Strings for each character.  Also updated the Resource case to resize String up front, since size is known.
This commit is contained in:
aaronp64 2025-05-12 11:42:41 -04:00
parent 19bb18716e
commit 8fb3697916
3 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

7
core/io/resource.cpp
View file

@ -142,15 +142,18 @@ String Resource::generate_scene_unique_id() {
static constexpr uint32_t char_count = ('z' - 'a');
static constexpr uint32_t base = char_count + ('9' - '0');
String id;
id.resize(characters + 1);
char32_t *ptr = id.ptrw();
for (uint32_t i = 0; i < characters; i++) {
uint32_t c = random_num % base;
if (c < char_count) {
id += String::chr('a' + c);
ptr[i] = ('a' + c);
} else {
id += String::chr('0' + (c - char_count));
ptr[i] = ('0' + (c - char_count));
}
random_num /= base;
}
ptr[characters] = '\0';
return id;
}

4
core/math/expression.cpp
View file

@ -408,7 +408,7 @@ Error Expression::_get_token(Token &r_token) {
if (reading == READING_DONE) {
break;
}
num += String::chr(c);
num += c;
c = GET_CHAR();
is_first_char = false;
}
@ -435,7 +435,7 @@ Error Expression::_get_token(Token &r_token) {
cchar = GET_CHAR();
while (is_unicode_identifier_continue(cchar)) {
id += String::chr(cchar);
id += cchar;
cchar = GET_CHAR();
}

4
core/variant/variant_parser.cpp
View file

@ -1757,7 +1757,7 @@ Error VariantParser::_parse_tag(Token &token, Stream *p_stream, int &line, Strin
} else {
escaping = false;
}
r_tag.name += String::chr(c);
r_tag.name += c;
}
}
@ -1902,7 +1902,7 @@ Error VariantParser::parse_tag_assign_eof(Stream *p_stream, int &line, String &r
what = tk.value;
} else if (c != '=') {
what += String::chr(c);
what += c;
} else {
r_assign = what;
Token token;