Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-10-25 18:54:43 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add warning checks in GDScript analyzer

Browse source 
Reenable checking those when validating code.
This commit is contained in:
George Marques 2020-06-11 19:31:28 -03:00
parent 9a76ab8b6a
commit 95c0909290
No known key found for this signature in database
GPG key ID: 046BD46A3201E43D
11 changed files with 618 additions and 185 deletions
Download patch file Download diff file Expand all files Collapse all files

30
modules/gdscript/gdscript_editor.cpp
View file

@ -134,23 +134,25 @@ bool GDScriptLanguage::validate(const String &p_script, int &r_line_error, int &
GDScriptAnalyzer analyzer(&parser);
Error err = parser.parse(p_script, p_path, false);
#ifdef DEBUG_ENABLED
// FIXME: Warnings.
// if (r_warnings) {
// for (const List<GDScriptWarning>::Element *E = parser.get_warnings().front(); E; E = E->next()) {
// const GDScriptWarning &warn = E->get();
// ScriptLanguage::Warning w;
// w.line = warn.line;
// w.code = (int)warn.code;
// w.string_code = GDScriptWarning::get_name_from_code(warn.code);
// w.message = warn.get_message();
// r_warnings->push_back(w);
// }
// }
#endif
if (err == OK) {
err = analyzer.analyze();
}
#ifdef DEBUG_ENABLED
if (r_warnings) {
for (const List<GDScriptWarning>::Element *E = parser.get_warnings().front(); E; E = E->next()) {
const GDScriptWarning &warn = E->get();
ScriptLanguage::Warning w;
w.start_line = warn.start_line;
w.end_line = warn.end_line;
w.leftmost_column = warn.leftmost_column;
w.rightmost_column = warn.rightmost_column;
w.code = (int)warn.code;
w.string_code = GDScriptWarning::get_name_from_code(warn.code);
w.message = warn.get_message();
r_warnings->push_back(w);
}
}
#endif
if (err) {
GDScriptParser::ParserError parse_error = parser.get_errors().front()->get();
r_line_error = parse_error.line;