From a2b9fc08e31eeb3f40be0ea1ff1f32b25ec52656 Mon Sep 17 00:00:00 2001
From: Kaleb Reid <78945904+Kaleb-Reid@users.noreply.github.com>
Date: Sun, 4 May 2025 22:20:48 -0700
Subject: [PATCH] Fix ghost collisions in segment_intersects_convex()

---
 core/math/geometry_3d.h            | 4 ++++
 tests/core/math/test_geometry_3d.h | 1 +
 2 files changed, 5 insertions(+)

diff --git a/core/math/geometry_3d.h b/core/math/geometry_3d.h
index bd8dbe439e1..fd945c17f89 100644
--- a/core/math/geometry_3d.h
+++ b/core/math/geometry_3d.h
@@ -292,6 +292,10 @@ public:
 			real_t den = p.normal.dot(dir);
 
 			if (Math::abs(den) <= (real_t)CMP_EPSILON) {
+				if (p.is_point_over(p_from)) {
+					// Separating plane.
+					return false;
+				}
 				continue; // Ignore parallel plane.
 			}
 
diff --git a/tests/core/math/test_geometry_3d.h b/tests/core/math/test_geometry_3d.h
index 39526bb2d03..b44e85ee4a4 100644
--- a/tests/core/math/test_geometry_3d.h
+++ b/tests/core/math/test_geometry_3d.h
@@ -160,6 +160,7 @@ TEST_CASE("[Geometry3D] Does Segment Intersect Convex") {
 	CHECK(Geometry3D::segment_intersects_convex(Vector3(10, 10, 10), Vector3(0, 0, 0), &box_planes[0], box_planes.size(), &result, &normal) == true);
 	CHECK(Geometry3D::segment_intersects_convex(Vector3(10, 10, 10), Vector3(5, 5, 5), &box_planes[0], box_planes.size(), &result, &normal) == true);
 	CHECK(Geometry3D::segment_intersects_convex(Vector3(10, 10, 10), Vector3(6, 5, 5), &box_planes[0], box_planes.size(), &result, &normal) == false);
+	CHECK(Geometry3D::segment_intersects_convex(Vector3(10, 10, 0), Vector3(10, 0, 0), &box_planes[0], box_planes.size(), &result, &normal) == false);
 }
 
 TEST_CASE("[Geometry3D] Segment Intersects Cylinder") {