Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-07 22:00:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

Improve ContainerTypeValidate performance for object types

Browse source 
Use const reference for class name instead of copying, to avoid some extra reference counting overhead
This commit is contained in:
aaronp64 2024-12-05 11:16:43 -05:00
parent 1f47e4c4e3
commit b19ebbacb2
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
core/variant/container_type_validate.h
View file

@ -124,9 +124,9 @@ struct ContainerTypeValidate {
return true; // All good, no class type requested.
}
StringName obj_class = object->get_class_name();
const StringName &obj_class = object->get_class_name();
if (obj_class != class_name) {
ERR_FAIL_COND_V_MSG(!ClassDB::is_parent_class(object->get_class_name(), class_name), false, vformat("Attempted to %s an object of type '%s' into a %s, which does not inherit from '%s'.", String(p_operation), object->get_class(), where, String(class_name)));
ERR_FAIL_COND_V_MSG(!ClassDB::is_parent_class(obj_class, class_name), false, vformat("Attempted to %s an object of type '%s' into a %s, which does not inherit from '%s'.", String(p_operation), object->get_class(), where, String(class_name)));
}
if (script.is_null()) {