From bcd99bdb172c23e0582dd1b3d723a4202bf2eded Mon Sep 17 00:00:00 2001 From: Caiman <103377610+caimantilla@users.noreply.github.com> Date: Wed, 12 Feb 2025 21:34:13 -0500 Subject: [PATCH] Fix GraphEdit::frame_rect_changed signal parameter type Changes the parameter type from Vector2 to Rect2, which is what is actually emitted. --- doc/classes/GraphEdit.xml | 2 +- misc/extension_api_validation/4.3-stable.expected | 7 +++++++ scene/gui/graph_edit.cpp | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/doc/classes/GraphEdit.xml b/doc/classes/GraphEdit.xml index 70137988e61..1d7ba4cf098 100644 --- a/doc/classes/GraphEdit.xml +++ b/doc/classes/GraphEdit.xml @@ -469,7 +469,7 @@ - + Emitted when the [GraphFrame] [param frame] is resized to [param new_rect]. diff --git a/misc/extension_api_validation/4.3-stable.expected b/misc/extension_api_validation/4.3-stable.expected index 2702a427109..ad2bd0ee0ad 100644 --- a/misc/extension_api_validation/4.3-stable.expected +++ b/misc/extension_api_validation/4.3-stable.expected @@ -319,3 +319,10 @@ GH-100913 Validate extension JSON: Error: Field 'classes/TextEdit/methods/get_line_column_at_pos/arguments': size changed value in new API, from 2 to 3. Added optional argument to disallow positions that are outside the column range of the line. Compatibility method registered. + + +GH-102796 +--------- +Validate extension JSON: Error: Field 'classes/GraphEdit/signals/frame_rect_changed/arguments/1': type changed value in new API, from "Vector2" to "Rect2". + +Previous type was incorrect. No compatibility system for signal arguments. diff --git a/scene/gui/graph_edit.cpp b/scene/gui/graph_edit.cpp index caa05909cc9..d0bf8d7819e 100644 --- a/scene/gui/graph_edit.cpp +++ b/scene/gui/graph_edit.cpp @@ -2834,7 +2834,7 @@ void GraphEdit::_bind_methods() { ADD_SIGNAL(MethodInfo("node_selected", PropertyInfo(Variant::OBJECT, "node", PROPERTY_HINT_RESOURCE_TYPE, "Node"))); ADD_SIGNAL(MethodInfo("node_deselected", PropertyInfo(Variant::OBJECT, "node", PROPERTY_HINT_RESOURCE_TYPE, "Node"))); - ADD_SIGNAL(MethodInfo("frame_rect_changed", PropertyInfo(Variant::OBJECT, "frame", PROPERTY_HINT_RESOURCE_TYPE, "GraphFrame"), PropertyInfo(Variant::VECTOR2, "new_rect"))); + ADD_SIGNAL(MethodInfo("frame_rect_changed", PropertyInfo(Variant::OBJECT, "frame", PROPERTY_HINT_RESOURCE_TYPE, "GraphFrame"), PropertyInfo(Variant::RECT2, "new_rect"))); ADD_SIGNAL(MethodInfo("popup_request", PropertyInfo(Variant::VECTOR2, "at_position")));