Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-10-19 07:53:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #104509 from HolonProduction/completion-super-method

Browse source 
GDScript: Return early when parsing invalid super call
This commit is contained in:
Thaddeus Crews 2025-03-24 15:27:26 -05:00
commit c687e4f692
No known key found for this signature in database
GPG key ID: 62181B86FE9E5D84
5 changed files with 29 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
modules/gdscript/gdscript_parser.cpp
View file

@ -3301,7 +3301,11 @@ GDScriptParser::ExpressionNode *GDScriptParser::parse_call(ExpressionNode *p_pre
IdentifierNode *identifier = parse_identifier();
call->callee = identifier;
call->function_name = identifier->name;
consume(GDScriptTokenizer::Token::PARENTHESIS_OPEN, R"(Expected "(" after function name.)");
if (!consume(GDScriptTokenizer::Token::PARENTHESIS_OPEN, R"(Expected "(" after function name.)")) {
pop_multiline();
complete_extents(call);
return nullptr;
}
}
} else {
call->callee = p_previous_operand;

5
modules/gdscript/tests/scripts/completion/common/invalid_super_call_1.cfg Normal file
View file

@ -0,0 +1,5 @@
[output]
include=[
; GDScript: class_a.notest.gd
{"display": "func_of_a()"},
]

7
modules/gdscript/tests/scripts/completion/common/invalid_super_call_1.gd Normal file
View file

@ -0,0 +1,7 @@
extends "res://completion/class_a.notest.gd"
func test():
super.➡
if true:
pass

5
modules/gdscript/tests/scripts/completion/common/invalid_super_call_2.cfg Normal file
View file

@ -0,0 +1,5 @@
[output]
include=[
; GDScript: class_a.notest.gd
{"display": "func_of_a()"},
]

7
modules/gdscript/tests/scripts/completion/common/invalid_super_call_2.gd Normal file
View file

@ -0,0 +1,7 @@
extends "res://completion/class_a.notest.gd"
func test():
super.f➡
if true:
pass