Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-08 06:09:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #111806 from Calinou/renderer-message-warnings

Browse source 
Make all unsupported renderer message features consistently warnings
This commit is contained in:
Rémi Verschelde 2025-12-02 14:15:43 +01:00
commit c87dd8e02b
No known key found for this signature in database
GPG key ID: C3336907360768E1
12 changed files with 47 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

10
editor/editor_node.cpp
View file

@ -7521,7 +7521,7 @@ void EditorNode::_renderer_selected(int p_index) {
const String web_rendering_method = "gl_compatibility";
video_restart_dialog->connect(SceneStringName(confirmed), callable_mp(this, &EditorNode::_set_renderer_name_save_and_restart).bind(rendering_method));
video_restart_dialog->set_text(
vformat(TTR("Changing the renderer requires restarting the editor.\n\nChoosing Save & Restart will change the rendering method to:\n- Desktop platforms: %s\n- Mobile platforms: %s\n- Web platform: %s"),
vformat(TTR("Changing the renderer requires restarting the editor.\n\nChoosing Save & Restart will change the renderer to:\n- Desktop platforms: %s\n- Mobile platforms: %s\n- Web platform: %s"),
_to_rendering_method_display_name(rendering_method), _to_rendering_method_display_name(mobile_rendering_method), _to_rendering_method_display_name(web_rendering_method)));
video_restart_dialog->popup_centered();
@ -7545,11 +7545,11 @@ void EditorNode::_set_renderer_name_save_and_restart(const String &p_rendering_m
ProjectSettings::get_singleton()->set("rendering/renderer/rendering_method", p_rendering_method);
if (p_rendering_method == "mobile" || p_rendering_method == "gl_compatibility") {
// Also change the mobile override if changing to a compatible rendering method.
// Also change the mobile override if changing to a compatible renderer.
// This prevents visual discrepancies between desktop and mobile platforms.
ProjectSettings::get_singleton()->set("rendering/renderer/rendering_method.mobile", p_rendering_method);
} else if (p_rendering_method == "forward_plus") {
// Use the equivalent mobile rendering method. This prevents the rendering method from staying
// Use the equivalent mobile renderer. This prevents the renderer from staying
// on its old choice if moving from `gl_compatibility` to `forward_plus`.
ProjectSettings::get_singleton()->set("rendering/renderer/rendering_method.mobile", "mobile");
}
@ -8675,8 +8675,8 @@ EditorNode::EditorNode() {
renderer->set_focus_mode(Control::FOCUS_ACCESSIBILITY);
renderer->set_auto_translate_mode(AUTO_TRANSLATE_MODE_DISABLED);
renderer->set_tooltip_auto_translate_mode(AUTO_TRANSLATE_MODE_ALWAYS);
renderer->set_tooltip_text(TTRC("Choose a rendering method.\n\nNotes:\n- On mobile platforms, the Mobile rendering method is used if Forward+ is selected here.\n- On the web platform, the Compatibility rendering method is always used."));
renderer->set_accessibility_name(TTRC("Rendering Method"));
renderer->set_tooltip_text(TTRC("Choose a renderer.\n\nNotes:\n- On mobile platforms, the Mobile renderer is used if Forward+ is selected here.\n- On the web platform, the Compatibility renderer is always used."));
renderer->set_accessibility_name(TTRC("Renderer"));
right_menu_hb->add_child(renderer);