Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-01 22:21:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

Portals - Fix secondary PVS bug

Browse source 
Fixes a bug whereby it read from the primary PVS in the gameplay monitor, using the size from the secondary PVS. This would read out of bounds and crash.

Removed debug code to update the gameplay monitor from the preview camera - this is no longer required.

Temporarily revert to the simple PVS generation method, because I've noticed a bug in the complex version, and the simple version is safer while I fix this.
This commit is contained in:
lawnjelly 2021-08-08 14:02:38 +01:00
parent 42e40a7d3c
commit cfe806a929
3 changed files with 17 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

4
servers/visual/portals/portal_pvs_builder.cpp
View file

@ -272,8 +272,8 @@ void PVSBuilder::calculate_pvs(PortalRenderer &p_portal_renderer, String p_filen
log("pvs from room : " + itos(n));
// trace_rooms_recursive_simple(0, n, n, -1, false, -1, dummy_planes, bf);
trace_rooms_recursive(0, n, n, -1, false, -1, dummy_planes, bf);
trace_rooms_recursive_simple(0, n, n, -1, false, -1, dummy_planes, bf);
// trace_rooms_recursive(0, n, n, -1, false, -1, dummy_planes, bf);
create_secondary_pvs(n, neighbors, bf);