mirror of
				https://github.com/godotengine/godot.git
				synced 2025-10-31 05:31:01 +00:00 
			
		
		
		
	Improve bookmarks
This commit is contained in:
		
							parent
							
								
									da617b7943
								
							
						
					
					
						commit
						e12b482022
					
				
					 6 changed files with 157 additions and 31 deletions
				
			
		|  | @ -366,6 +366,9 @@ void ShaderEditor::_bind_methods() { | |||
| 	ClassDB::bind_method("_editor_settings_changed", &ShaderEditor::_editor_settings_changed); | ||||
| 	ClassDB::bind_method("_text_edit_gui_input", &ShaderEditor::_text_edit_gui_input); | ||||
| 
 | ||||
| 	ClassDB::bind_method("_update_bookmark_list", &ShaderEditor::_update_bookmark_list); | ||||
| 	ClassDB::bind_method("_bookmark_item_pressed", &ShaderEditor::_bookmark_item_pressed); | ||||
| 
 | ||||
| 	ClassDB::bind_method("_menu_option", &ShaderEditor::_menu_option); | ||||
| 	ClassDB::bind_method("_params_changed", &ShaderEditor::_params_changed); | ||||
| 	ClassDB::bind_method("apply_shaders", &ShaderEditor::apply_shaders); | ||||
|  | @ -465,6 +468,43 @@ void ShaderEditor::_text_edit_gui_input(const Ref<InputEvent> &ev) { | |||
| 	} | ||||
| } | ||||
| 
 | ||||
| void ShaderEditor::_update_bookmark_list() { | ||||
| 
 | ||||
| 	bookmarks_menu->get_popup()->clear(); | ||||
| 
 | ||||
| 	bookmarks_menu->get_popup()->add_shortcut(ED_GET_SHORTCUT("script_text_editor/toggle_bookmark"), BOOKMARK_TOGGLE); | ||||
| 	bookmarks_menu->get_popup()->add_shortcut(ED_GET_SHORTCUT("script_text_editor/remove_all_bookmarks"), BOOKMARK_REMOVE_ALL); | ||||
| 	bookmarks_menu->get_popup()->add_shortcut(ED_GET_SHORTCUT("script_text_editor/goto_next_bookmark"), BOOKMARK_GOTO_NEXT); | ||||
| 	bookmarks_menu->get_popup()->add_shortcut(ED_GET_SHORTCUT("script_text_editor/goto_previous_bookmark"), BOOKMARK_GOTO_PREV); | ||||
| 
 | ||||
| 	Array bookmark_list = shader_editor->get_text_edit()->get_bookmarks_array(); | ||||
| 	if (bookmark_list.size() == 0) { | ||||
| 		return; | ||||
| 	} | ||||
| 
 | ||||
| 	bookmarks_menu->get_popup()->add_separator(); | ||||
| 
 | ||||
| 	for (int i = 0; i < bookmark_list.size(); i++) { | ||||
| 		String line = shader_editor->get_text_edit()->get_line(bookmark_list[i]).strip_edges(); | ||||
| 		// Limit the size of the line if too big.
 | ||||
| 		if (line.length() > 50) { | ||||
| 			line = line.substr(0, 50); | ||||
| 		} | ||||
| 
 | ||||
| 		bookmarks_menu->get_popup()->add_item(String::num((int)bookmark_list[i] + 1) + " - \"" + line + "\""); | ||||
| 		bookmarks_menu->get_popup()->set_item_metadata(bookmarks_menu->get_popup()->get_item_count() - 1, bookmark_list[i]); | ||||
| 	} | ||||
| } | ||||
| 
 | ||||
| void ShaderEditor::_bookmark_item_pressed(int p_idx) { | ||||
| 
 | ||||
| 	if (p_idx < 4) { // Any item before the separator.
 | ||||
| 		_menu_option(bookmarks_menu->get_popup()->get_item_id(p_idx)); | ||||
| 	} else { | ||||
| 		shader_editor->goto_line(bookmarks_menu->get_popup()->get_item_metadata(p_idx)); | ||||
| 	} | ||||
| } | ||||
| 
 | ||||
| void ShaderEditor::_make_context_menu(bool p_selection) { | ||||
| 
 | ||||
| 	context_menu->clear(); | ||||
|  | @ -483,6 +523,7 @@ void ShaderEditor::_make_context_menu(bool p_selection) { | |||
| 	context_menu->add_shortcut(ED_GET_SHORTCUT("script_text_editor/indent_left"), EDIT_INDENT_LEFT); | ||||
| 	context_menu->add_shortcut(ED_GET_SHORTCUT("script_text_editor/indent_right"), EDIT_INDENT_RIGHT); | ||||
| 	context_menu->add_shortcut(ED_GET_SHORTCUT("script_text_editor/toggle_comment"), EDIT_TOGGLE_COMMENT); | ||||
| 	context_menu->add_shortcut(ED_GET_SHORTCUT("script_text_editor/toggle_bookmark"), BOOKMARK_TOGGLE); | ||||
| 
 | ||||
| 	context_menu->set_position(get_global_transform().xform(get_local_mouse_position())); | ||||
| 	context_menu->set_size(Vector2(1, 1)); | ||||
|  | @ -553,20 +594,18 @@ ShaderEditor::ShaderEditor(EditorNode *p_node) { | |||
| 	search_menu->get_popup()->add_shortcut(ED_GET_SHORTCUT("script_text_editor/goto_line"), SEARCH_GOTO_LINE); | ||||
| 	search_menu->get_popup()->connect("id_pressed", this, "_menu_option"); | ||||
| 
 | ||||
| 	PopupMenu *bookmarks = memnew(PopupMenu); | ||||
| 	bookmarks->set_name("bookmarks"); | ||||
| 	edit_menu->get_popup()->add_child(bookmarks); | ||||
| 	edit_menu->get_popup()->add_submenu_item(TTR("Bookmarks"), "bookmarks"); | ||||
| 	bookmarks->add_shortcut(ED_GET_SHORTCUT("script_text_editor/toggle_bookmark"), BOOKMARK_TOGGLE); | ||||
| 	bookmarks->add_shortcut(ED_GET_SHORTCUT("script_text_editor/remove_all_bookmarks"), BOOKMARK_REMOVE_ALL); | ||||
| 	bookmarks->add_shortcut(ED_GET_SHORTCUT("script_text_editor/goto_next_bookmark"), BOOKMARK_GOTO_NEXT); | ||||
| 	bookmarks->add_shortcut(ED_GET_SHORTCUT("script_text_editor/goto_previous_bookmark"), BOOKMARK_GOTO_PREV); | ||||
| 	bookmarks->connect("id_pressed", this, "_edit_option"); | ||||
| 	bookmarks_menu = memnew(MenuButton); | ||||
| 	bookmarks_menu->set_text(TTR("Bookmarks")); | ||||
| 	bookmarks_menu->set_switch_on_hover(true); | ||||
| 	_update_bookmark_list(); | ||||
| 	bookmarks_menu->connect("about_to_show", this, "_update_bookmark_list"); | ||||
| 	bookmarks_menu->get_popup()->connect("index_pressed", this, "_bookmark_item_pressed"); | ||||
| 
 | ||||
| 	add_child(main_container); | ||||
| 	main_container->add_child(hbc); | ||||
| 	hbc->add_child(search_menu); | ||||
| 	hbc->add_child(edit_menu); | ||||
| 	hbc->add_child(bookmarks_menu); | ||||
| 	hbc->add_style_override("panel", p_node->get_gui_base()->get_stylebox("ScriptEditorPanel", "EditorStyles")); | ||||
| 	main_container->add_child(shader_editor); | ||||
| 
 | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue
	
	 Michael Alexsander Silva Dias
						Michael Alexsander Silva Dias