Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-08 06:09:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #100333 from YYF233333/reduce_list

Browse source 
Use `LocalVector` instead of `List` as arg of `Dictionary::get_key_list`
This commit is contained in:
Thaddeus Crews 2025-04-09 08:51:45 -05:00
commit ec675fc329
No known key found for this signature in database
GPG key ID: 8C6E5FEB5FC03CCC
13 changed files with 33 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

15
tests/core/variant/test_dictionary.h
View file

@ -115,19 +115,18 @@ TEST_CASE("[Dictionary] List init") {
CHECK_EQ(tdict[5.0], Variant(2.0));
}
TEST_CASE("[Dictionary] get_key_lists()") {
TEST_CASE("[Dictionary] get_key_list()") {
Dictionary map;
List<Variant> keys;
List<Variant> *ptr = &keys;
map.get_key_list(ptr);
LocalVector<Variant> keys;
keys = map.get_key_list();
CHECK(keys.is_empty());
map[1] = 3;
map.get_key_list(ptr);
keys = map.get_key_list();
CHECK(keys.size() == 1);
CHECK(int(keys.front()->get()) == 1);
CHECK(int(keys[0]) == 1);
map[2] = 4;
map.get_key_list(ptr);
CHECK(keys.size() == 3);
keys = map.get_key_list();
CHECK(keys.size() == 2);
}
TEST_CASE("[Dictionary] get_key_at_index()") {