Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-10-20 00:13:30 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #92584 from HolonProduction/autocompletion-assign-variant

Browse source 
Autocompletion: Fix type resolution when assigning variant
This commit is contained in:
Thaddeus Crews 2025-07-01 17:57:51 -05:00
commit ee5859b7ae
No known key found for this signature in database
GPG key ID: 8C6E5FEB5FC03CCC
3 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
modules/gdscript/gdscript_editor.cpp
View file

@ -1643,6 +1643,8 @@ static GDScriptCompletionIdentifier _type_from_property(const PropertyInfo &p_pr
if (p_property.type == Variant::NIL) {
// Variant
ci.type.type_source = GDScriptParser::DataType::ANNOTATED_EXPLICIT;
ci.type.kind = GDScriptParser::DataType::VARIANT;
return ci;
}
@ -2341,7 +2343,7 @@ static bool _guess_identifier_type(GDScriptParser::CompletionContext &p_context,
c.current_line = last_assign_line;
GDScriptCompletionIdentifier assigned_type;
if (_guess_expression_type(c, last_assigned_expression, assigned_type)) {
if (id_type.type.is_set() && assigned_type.type.is_set() && !GDScriptAnalyzer::check_type_compatibility(id_type.type, assigned_type.type)) {
if (id_type.type.is_set() && (assigned_type.type.kind == GDScriptParser::DataType::VARIANT || (assigned_type.type.is_set() && !GDScriptAnalyzer::check_type_compatibility(id_type.type, assigned_type.type)))) {
// The assigned type is incompatible. The annotated type takes priority.
r_type = id_type;
r_type.assigned_expression = last_assigned_expression;