Stowage/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-07 22:00:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

Project Manager: Fix hacky code for project rename

Browse source 
Instantiating a new ProjectSettings is *not* the way to go.
ConfigFile works just fine to read/change a single value.

Fixes memory leaks as the instantiated ProjectSettings was never freed.
Forbid doing this to prevent such problems.

Fixes #25661.
This commit is contained in:
Rémi Verschelde 2022-11-29 15:20:15 +01:00
parent 6fdbf79046
commit f21f75eb6f
No known key found for this signature in database
GPG key ID: C3336907360768E1
2 changed files with 19 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

1
core/config/project_settings.cpp
View file

@ -1200,6 +1200,7 @@ ProjectSettings::ProjectSettings() {
// Initialization of engine variables should be done in the setup() method,
// so that the values can be overridden from project.godot or project.binary.
CRASH_COND_MSG(singleton != nullptr, "Instantiating a new ProjectSettings singleton is not supported.");
singleton = this;
GLOBAL_DEF_BASIC("application/config/name", "");