mirror of
https://github.com/godotengine/godot.git
synced 2025-12-08 06:09:55 +00:00
ab205a78ce
This race condition made me pull my hair. `wl_display_roundtrip` has its own little event loop, which apparently conflicts hard with the always-running event loop thread. I kinda assumed that it would be thread-safe thanks to its internal `wl_display_prepare_read` call that the docs talk about but that's clearly not enough. Luckily this method is called very few times and the only dangerous instances are in the initialization routine, which first starts the thread and then does various roundtrips. Libdecor has also some internal roundtrips of its own which would often fail. Starting the thread after all initialization fixes the issue. Tested this by spamming *lots* of `wl_display_roundtrip` in `WaylandThread::init()` with and without this fix. |
||
|---|---|---|
| .. | ||
| dynwrappers | ||
| detect_prime_egl.cpp | ||
| detect_prime_egl.h | ||
| display_server_wayland.cpp | ||
| display_server_wayland.h | ||
| egl_manager_wayland.cpp | ||
| egl_manager_wayland.h | ||
| egl_manager_wayland_gles.cpp | ||
| egl_manager_wayland_gles.h | ||
| key_mapping_xkb.cpp | ||
| key_mapping_xkb.h | ||
| rendering_context_driver_vulkan_wayland.cpp | ||
| rendering_context_driver_vulkan_wayland.h | ||
| SCsub | ||
| wayland_thread.cpp | ||
| wayland_thread.h | ||