Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-20 08:03:21 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Userland/Libraries/LibWeb/CSS/CSSImportRule.h

60 lines
1.7 KiB
C
Raw Normal View History

LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
/*
* Copyright (c) 2021, the SerenityOS developers.
LibWeb: Make `@import` rules functional again :^) The changes in commit d462a6720afe721b6821ce14d5b7802d1890b61f meant that `CSSLoader::load_next_import_if_needed()` was no longer being called, so no `@import` rules were loading. The spec does not seem to mention when that loading should take place, but WebKit does this at parse time, as each rule is added to the style sheet. If it works for them, it's probably not that bad. :^) So, that's what we now do here. The `CSSImportRule` creates a fetch request when it is constructed, so each one is responsible for its own contents.
2021-11-18 17:34:53 +00:00
* Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org>
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 01:24:48 -07:00
* SPDX-License-Identifier: BSD-2-Clause
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
*/
#pragma once
#include <AK/URL.h>
#include <LibWeb/CSS/CSSRule.h>
LibWeb: Resolve cyclic dependency between StyleSheet and ImportRule Previously: CSSImportRule::loaded_style_sheet() (and others) depend on the definition of class CSSStyleSheet. Meanwhile, CSSStyleSheet::template for_each_effective_style_rule (and others) depend on the definition of class CSSImportRule. This hasn't caused any problems so far because CSSStyleSheet.h happened to be always included after CSSImportRule.h (in part due to alphabetical ordering). However, a compilation unit that (for example) only contains #include <Userland/Libraries/LibWeb/CSSImportRule.h> would fail to compile. This patch resolves this issue by pushing the inline definition of Web::CSS::CSSStyleSheet::for_each_effective_style_rule and for_first_not_loaded_import_rule into a different file, and adding the missing headers.
2021-09-30 22:57:35 +02:00
#include <LibWeb/CSS/CSSStyleSheet.h>
LibWeb: Make `@import` rules functional again :^) The changes in commit d462a6720afe721b6821ce14d5b7802d1890b61f meant that `CSSLoader::load_next_import_if_needed()` was no longer being called, so no `@import` rules were loading. The spec does not seem to mention when that loading should take place, but WebKit does this at parse time, as each rule is added to the style sheet. If it works for them, it's probably not that bad. :^) So, that's what we now do here. The `CSSImportRule` creates a fetch request when it is constructed, so each one is responsible for its own contents.
2021-11-18 17:34:53 +00:00
#include <LibWeb/DOM/DocumentLoadEventDelayer.h>
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
namespace Web::CSS {
LibWeb: Make `@import` rules functional again :^) The changes in commit d462a6720afe721b6821ce14d5b7802d1890b61f meant that `CSSLoader::load_next_import_if_needed()` was no longer being called, so no `@import` rules were loading. The spec does not seem to mention when that loading should take place, but WebKit does this at parse time, as each rule is added to the style sheet. If it works for them, it's probably not that bad. :^) So, that's what we now do here. The `CSSImportRule` creates a fetch request when it is constructed, so each one is responsible for its own contents.
2021-11-18 17:34:53 +00:00
class CSSImportRule
: public CSSRule
, public ResourceClient {
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
AK_MAKE_NONCOPYABLE(CSSImportRule);
AK_MAKE_NONMOVABLE(CSSImportRule);
public:
LibWeb: Make `@import` rules functional again :^) The changes in commit d462a6720afe721b6821ce14d5b7802d1890b61f meant that `CSSLoader::load_next_import_if_needed()` was no longer being called, so no `@import` rules were loading. The spec does not seem to mention when that loading should take place, but WebKit does this at parse time, as each rule is added to the style sheet. If it works for them, it's probably not that bad. :^) So, that's what we now do here. The `CSSImportRule` creates a fetch request when it is constructed, so each one is responsible for its own contents.
2021-11-18 17:34:53 +00:00
static NonnullRefPtr<CSSImportRule> create(AK::URL url, DOM::Document& document)
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
{
LibWeb: Make `@import` rules functional again :^) The changes in commit d462a6720afe721b6821ce14d5b7802d1890b61f meant that `CSSLoader::load_next_import_if_needed()` was no longer being called, so no `@import` rules were loading. The spec does not seem to mention when that loading should take place, but WebKit does this at parse time, as each rule is added to the style sheet. If it works for them, it's probably not that bad. :^) So, that's what we now do here. The `CSSImportRule` creates a fetch request when it is constructed, so each one is responsible for its own contents.
2021-11-18 17:34:53 +00:00
return adopt_ref(*new CSSImportRule(move(url), document));
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
}
Libraries: Use default constructors/destructors in LibWeb https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules "The compiler is more likely to get the default semantics right and you cannot implement these functions better than the compiler."
2022-03-14 13:21:51 -06:00
~CSSImportRule() = default;
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
LibWeb: Add the Web::URL namespace and move URLEncoder to it This namespace will be used for all interfaces defined in the URL specification, like URL and URLSearchParams. This has the unfortunate side-effect of requiring us to use the fully qualified AK::URL name whenever we want to refer to the AK class, so this commit also fixes all such references.
2021-09-13 00:33:23 +03:00
const AK::URL& url() const { return m_url; }
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
LibWeb: Add actual document loading for the CSS (at)import rule
2021-02-21 18:44:17 +02:00
bool has_import_result() const { return !m_style_sheet.is_null(); }
LibWeb: Split CSS::StyleSheet into StyleSheet and CSSStyleSheet This is a little convoluted but matches the CSSOM specification.
2021-03-07 16:14:04 +01:00
RefPtr<CSSStyleSheet> loaded_style_sheet() { return m_style_sheet; }
const RefPtr<CSSStyleSheet> loaded_style_sheet() const { return m_style_sheet; }
LibWeb: CSSImportRule::set_style_sheet() should take a CSSStyleSheet Spotted by @tomuta in #6086.
2021-04-03 11:55:37 +02:00
void set_style_sheet(const RefPtr<CSSStyleSheet>& style_sheet) { m_style_sheet = style_sheet; }
LibWeb: Add actual document loading for the CSS (at)import rule
2021-02-21 18:44:17 +02:00
Everywhere: Fix -Winconsistent-missing-override warnings from Clang This option is already enabled when building Lagom, so let's enable it for the main build too. We will no longer be surprised by Lagom Clang CI builds failing while everything compiles locally. Furthermore, the stronger `-Wsuggest-override` warning is enabled in this commit, which enforces the use of the `override` keyword in all classes, not just those which already have some methods marked as `override`. This works with both GCC and Clang.
2021-12-04 10:09:09 +01:00
virtual StringView class_name() const override { return "CSSImportRule"; };
virtual Type type() const override { return Type::Import; };
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
private:
LibWeb: Make `@import` rules functional again :^) The changes in commit d462a6720afe721b6821ce14d5b7802d1890b61f meant that `CSSLoader::load_next_import_if_needed()` was no longer being called, so no `@import` rules were loading. The spec does not seem to mention when that loading should take place, but WebKit does this at parse time, as each rule is added to the style sheet. If it works for them, it's probably not that bad. :^) So, that's what we now do here. The `CSSImportRule` creates a fetch request when it is constructed, so each one is responsible for its own contents.
2021-11-18 17:34:53 +00:00
explicit CSSImportRule(AK::URL, DOM::Document&);
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
LibWeb: Implement CSSRule and CSSStyleDeclaration serialization There are a handful of FIXME's here, but this seems generally good. Note that CSS *values* don't get serialized in a spec-compliant way since we currently rely on StyleValue::to_string() which is ad-hoc.
2021-10-01 19:57:45 +02:00
virtual String serialized() const override;
LibWeb: Make `@import` rules functional again :^) The changes in commit d462a6720afe721b6821ce14d5b7802d1890b61f meant that `CSSLoader::load_next_import_if_needed()` was no longer being called, so no `@import` rules were loading. The spec does not seem to mention when that loading should take place, but WebKit does this at parse time, as each rule is added to the style sheet. If it works for them, it's probably not that bad. :^) So, that's what we now do here. The `CSSImportRule` creates a fetch request when it is constructed, so each one is responsible for its own contents.
2021-11-18 17:34:53 +00:00
// ^ResourceClient
virtual void resource_did_fail() override;
virtual void resource_did_load() override;
LibWeb: Add the Web::URL namespace and move URLEncoder to it This namespace will be used for all interfaces defined in the URL specification, like URL and URLSearchParams. This has the unfortunate side-effect of requiring us to use the fully qualified AK::URL name whenever we want to refer to the AK class, so this commit also fixes all such references.
2021-09-13 00:33:23 +03:00
AK::URL m_url;
LibWeb: Make CSSImportRule::m_document a WeakPtr It's not safe for this to be a raw reference, as CSSImportRule can outlive the document.
2021-12-05 15:28:38 +01:00
WeakPtr<DOM::Document> m_document;
LibWeb: Make `@import` rules functional again :^) The changes in commit d462a6720afe721b6821ce14d5b7802d1890b61f meant that `CSSLoader::load_next_import_if_needed()` was no longer being called, so no `@import` rules were loading. The spec does not seem to mention when that loading should take place, but WebKit does this at parse time, as each rule is added to the style sheet. If it works for them, it's probably not that bad. :^) So, that's what we now do here. The `CSSImportRule` creates a fetch request when it is constructed, so each one is responsible for its own contents.
2021-11-18 17:34:53 +00:00
Optional<DOM::DocumentLoadEventDelayer> m_document_load_event_delayer;
LibWeb: Split CSS::StyleSheet into StyleSheet and CSSStyleSheet This is a little convoluted but matches the CSSOM specification.
2021-03-07 16:14:04 +01:00
RefPtr<CSSStyleSheet> m_style_sheet;
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
};
LibWeb: Add fast_is<T> for CSSRule subclasses Since we already have a type enum for these, let's use it to make is<T> bypass dynamic_cast for CSS rules. These were often near the top of random browser profiles.
2021-03-18 21:50:52 +01:00
template<>
inline bool CSSRule::fast_is<CSSImportRule>() const { return type() == CSSRule::Type::Import; }
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
}
Reference in a new issue Copy permalink