Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-11-03 23:00:58 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Libraries/LibWeb/HTML/Numbers.h

29 lines
746 B
C
Raw Normal View History

LibWeb: Implement spec-compliant integer parsing We have code inside LibWeb that uses the `AK::StringUtils::convert_to_uint`and `AK::StringUtils::convert_to_int` methods for parsing integers. This works well for the most part, but according to the spec, trailing characters are allowed and should be ignored, but this is not how the `StringUtil` methods are implemented. This patch adds two new methods named `parse_integer` and `parse_non_negative_integer` inside the `Web::HTML` namespace that uses `StringUtils` under the hood but adds a bit more logic to make it spec compliant.
2023-07-23 19:38:04 +03:00
/*
* Copyright (c) 2023, Jonatan Klemets <jonatan.r.klemets@gmail.com>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <AK/Forward.h>
#include <AK/String.h>
LibWeb: Add input and textarea minlength and maxlength support
2024-03-01 08:49:04 +01:00
#include <LibWeb/WebIDL/ExceptionOr.h>
#include <LibWeb/WebIDL/Types.h>
LibWeb: Implement spec-compliant integer parsing We have code inside LibWeb that uses the `AK::StringUtils::convert_to_uint`and `AK::StringUtils::convert_to_int` methods for parsing integers. This works well for the most part, but according to the spec, trailing characters are allowed and should be ignored, but this is not how the `StringUtil` methods are implemented. This patch adds two new methods named `parse_integer` and `parse_non_negative_integer` inside the `Web::HTML` namespace that uses `StringUtils` under the hood but adds a bit more logic to make it spec compliant.
2023-07-23 19:38:04 +03:00
namespace Web::HTML {
Optional<i32> parse_integer(StringView string);
LibWeb: Add `parse_integer_digits` methods The rules for parsing integers don't specify an upper bound on the value that can be returned, so the `parse_integer_digits` method can be used to check whether the given arbitrarily-large StringView is valid according to these rules. The `parse_integer` and `parse_non_negative_integer` methods would fail for values larger than 2147483647 when they shouldn't have.
2024-12-01 00:04:32 +00:00
Optional<StringView> parse_integer_digits(StringView string);
LibWeb: Implement spec-compliant integer parsing We have code inside LibWeb that uses the `AK::StringUtils::convert_to_uint`and `AK::StringUtils::convert_to_int` methods for parsing integers. This works well for the most part, but according to the spec, trailing characters are allowed and should be ignored, but this is not how the `StringUtil` methods are implemented. This patch adds two new methods named `parse_integer` and `parse_non_negative_integer` inside the `Web::HTML` namespace that uses `StringUtils` under the hood but adds a bit more logic to make it spec compliant.
2023-07-23 19:38:04 +03:00
Optional<u32> parse_non_negative_integer(StringView string);
LibWeb: Add `parse_integer_digits` methods The rules for parsing integers don't specify an upper bound on the value that can be returned, so the `parse_integer_digits` method can be used to check whether the given arbitrarily-large StringView is valid according to these rules. The `parse_integer` and `parse_non_negative_integer` methods would fail for values larger than 2147483647 when they shouldn't have.
2024-12-01 00:04:32 +00:00
Optional<StringView> parse_non_negative_integer_digits(StringView string);
LibWeb: Implement spec-compliant integer parsing We have code inside LibWeb that uses the `AK::StringUtils::convert_to_uint`and `AK::StringUtils::convert_to_int` methods for parsing integers. This works well for the most part, but according to the spec, trailing characters are allowed and should be ignored, but this is not how the `StringUtil` methods are implemented. This patch adds two new methods named `parse_integer` and `parse_non_negative_integer` inside the `Web::HTML` namespace that uses `StringUtils` under the hood but adds a bit more logic to make it spec compliant.
2023-07-23 19:38:04 +03:00
LibWeb: Add basic parse floating point number function
2023-11-15 19:54:01 +01:00
Optional<double> parse_floating_point_number(StringView string);
LibWeb: Add “valid floating-point number” for HTMLInputElement.value This change adds checking for the following spec requirements: - https://html.spec.whatwg.org/#number-state-(type=number):value-sanitization-algorithm - https://html.spec.whatwg.org/#range-state-(type=range):value-sanitization-algorithm That is, it adds checking that HTMLInputElement.value is what the spec defines as a “valid floating-point number” when the “type” attribute for the HTMLInputElement is either “number” or “range”. This change causes Ladybird to pass all the failing tests at https://wpt.fyi/results/html/semantics/forms/the-input-element/number.html?run_id=5080423051034624 and to match the relevant behavior in Webkit, Blink, and Gecko. Otherwise, without this change, Ladybird fails those tests, and the relevant Ladybird behavior isn’t interoperable with other engines.
2024-08-27 18:25:01 +09:00
bool is_valid_floating_point_number(StringView string);
LibWeb: Add input and textarea minlength and maxlength support
2024-03-01 08:49:04 +01:00
WebIDL::ExceptionOr<String> convert_non_negative_integer_to_string(JS::Realm&, WebIDL::Long);
LibWeb: Implement spec-compliant integer parsing We have code inside LibWeb that uses the `AK::StringUtils::convert_to_uint`and `AK::StringUtils::convert_to_int` methods for parsing integers. This works well for the most part, but according to the spec, trailing characters are allowed and should be ignored, but this is not how the `StringUtil` methods are implemented. This patch adds two new methods named `parse_integer` and `parse_non_negative_integer` inside the `Web::HTML` namespace that uses `StringUtils` under the hood but adds a bit more logic to make it spec compliant.
2023-07-23 19:38:04 +03:00
}
Reference in a new issue Copy permalink