Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-19 15:43:20 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Libraries/LibWeb/DOM/AbortController.cpp

51 lines
1.3 KiB
C++
Raw Normal View History

LibWeb: Add initial support for AbortController and AbortSignal The DOM specification says that the primary use case for these is to give Promises abort semantics. It is also a prerequisite for Fetch, as it is used to make Fetch abortable. a
2021-09-02 02:12:49 +01:00
/*
* Copyright (c) 2021, Luke Wilde <lukew@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
LibWeb: Remove Bindings/Forward.h from LibWeb/Forward.h This was resulting in a whole lot of rebuilding whenever a new IDL interface was added. Instead, just directly include the prototype in every C++ file which needs it. While we only really need a forward declaration in each cpp file; including the full prototype header (which itself only includes LibJS/Object.h, which is already transitively brought in by PlatformObject) - it seems like a small price to pay compared to what feels like a full rebuild of LibWeb whenever a new IDL file is added. Given all of these includes are only needed for the ::initialize method, there is probably a smart way of avoiding this problem altogether. I've considered both using some macro trickery or generating these functions somehow instead.
2024-04-27 12:09:58 +12:00
#include <LibWeb/Bindings/AbortControllerPrototype.h>
LibWeb: Remove unecessary dependence on Window from DOM and WebIDL These classes only needed Window to get at its realm. Pass a realm directly to construct DOM and WebIDL classes. This change importantly removes the guarantee that a Document will always have a non-null Window object. Only Documents created by a BrowsingContext will have a non-null Window object. Documents created by for example, DocumentFragment, will not have a Window (soon). This incremental commit leaves some workarounds in place to keep other parts of the code building.
2022-09-25 16:15:49 -06:00
#include <LibWeb/Bindings/Intrinsics.h>
LibWeb: Add initial support for AbortController and AbortSignal The DOM specification says that the primary use case for these is to give Promises abort semantics. It is also a prerequisite for Fetch, as it is used to make Fetch abortable. a
2021-09-02 02:12:49 +01:00
#include <LibWeb/DOM/AbortController.h>
#include <LibWeb/DOM/AbortSignal.h>
namespace Web::DOM {
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC_DEFINE_ALLOCATOR(AbortController);
LibWeb: Put most LibWeb GC objects in type-specific heap blocks With this change, we now have ~1200 CellAllocators across both LibJS and LibWeb in a normal WebContent instance. This gives us a minimum heap size of 4.7 MiB in the scenario where we only have one cell allocated per type. Of course, in practice there will be many more of each type, so the effective overhead is quite a bit smaller than that in practice. I left a few types unconverted to this mechanism because I got tired of doing this. :^)
2023-11-19 19:47:52 +01:00
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
WebIDL::ExceptionOr<GC::Ref<AbortController>> AbortController::construct_impl(JS::Realm& realm)
LibWeb: Make AbortController GC-allocated
2022-09-02 14:59:27 +02:00
{
LibWeb: Make factory method of DOM::AbortSignal fallible
2023-02-14 21:02:46 +01:00
auto signal = TRY(AbortSignal::construct_impl(realm));
LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T> The main motivation behind this is to remove JS specifics of the Realm from the implementation of the Heap. As a side effect of this change, this is a bit nicer to read than the previous approach, and in my opinion, also makes it a little more clear that this method is specific to a JavaScript Realm.
2024-11-14 05:50:17 +13:00
return realm.create<AbortController>(realm, move(signal));
LibWeb: Make AbortController GC-allocated
2022-09-02 14:59:27 +02:00
}
LibWeb: Add initial support for AbortController and AbortSignal The DOM specification says that the primary use case for these is to give Promises abort semantics. It is also a prerequisite for Fetch, as it is used to make Fetch abortable. a
2021-09-02 02:12:49 +01:00
// https://dom.spec.whatwg.org/#dom-abortcontroller-abortcontroller
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
AbortController::AbortController(JS::Realm& realm, GC::Ref<AbortSignal> signal)
LibWeb: Remove unecessary dependence on Window from DOM and WebIDL These classes only needed Window to get at its realm. Pass a realm directly to construct DOM and WebIDL classes. This change importantly removes the guarantee that a Document will always have a non-null Window object. Only Documents created by a BrowsingContext will have a non-null Window object. Documents created by for example, DocumentFragment, will not have a Window (soon). This incremental commit leaves some workarounds in place to keep other parts of the code building.
2022-09-25 16:15:49 -06:00
: PlatformObject(realm)
LibWeb: Make AbortController GC-allocated
2022-09-02 14:59:27 +02:00
, m_signal(move(signal))
{
}
AbortController::~AbortController() = default;
LibJS: Make Cell::initialize() return void Stop worrying about tiny OOMs. Work towards #20405
2023-08-07 08:41:28 +02:00
void AbortController::initialize(JS::Realm& realm)
LibWeb: Move setting of Web object prototypes to initialize() This needs to happen before prototype/constructor intitialization can be made lazy. Otherwise, GC could run during the C++ constructor and try to collect the object currently being created.
2023-01-10 06:28:20 -05:00
{
LibWeb: Avoid FlyString lookups when setting IDL interface prototypes This commit introduces a WEB_SET_PROTOTYPE_FOR_INTERFACE macro that caches the interface name in a local static FlyString. This means that we only pay for FlyString-from-literal lookup once per browser lifetime instead of every time the interface is instantiated.
2024-03-16 13:13:08 +01:00
WEB_SET_PROTOTYPE_FOR_INTERFACE(AbortController);
LibWeb: Only set prototype once for object with IDL interface Before this change, we were going through the chain of base classes for each IDL interface object and having them set the prototype to their prototype. Instead of doing that, reorder things so that we set the right prototype immediately in Foo::initialize(), and then don't bother in all the base class overrides. This knocks off a ~1% profile item on Speedometer 3.
2025-04-20 16:22:57 +02:00
Base::initialize(realm);
LibWeb: Move setting of Web object prototypes to initialize() This needs to happen before prototype/constructor intitialization can be made lazy. Otherwise, GC could run during the C++ constructor and try to collect the object currently being created.
2023-01-10 06:28:20 -05:00
}
LibWeb: Make AbortController GC-allocated
2022-09-02 14:59:27 +02:00
void AbortController::visit_edges(Cell::Visitor& visitor)
LibWeb: Add initial support for AbortController and AbortSignal The DOM specification says that the primary use case for these is to give Promises abort semantics. It is also a prerequisite for Fetch, as it is used to make Fetch abortable. a
2021-09-02 02:12:49 +01:00
{
LibWeb: Make AbortController GC-allocated
2022-09-02 14:59:27 +02:00
Base::visit_edges(visitor);
LibWeb/LibJS: Avoid GC visit of raw pointers where possible This is mostly motivated for aesthetics, but also helps avoid some null checks when we have a NonnullGCPtr<T> or in some cases a T&.
2023-11-19 16:18:00 +13:00
visitor.visit(m_signal);
LibWeb: Add initial support for AbortController and AbortSignal The DOM specification says that the primary use case for these is to give Promises abort semantics. It is also a prerequisite for Fetch, as it is used to make Fetch abortable. a
2021-09-02 02:12:49 +01:00
}
// https://dom.spec.whatwg.org/#dom-abortcontroller-abort
LibWeb: Add support for AbortSignal.reason
2021-12-10 20:05:12 +00:00
void AbortController::abort(JS::Value reason)
LibWeb: Add initial support for AbortController and AbortSignal The DOM specification says that the primary use case for these is to give Promises abort semantics. It is also a prerequisite for Fetch, as it is used to make Fetch abortable. a
2021-09-02 02:12:49 +01:00
{
LibWeb: Add support for AbortSignal.reason
2021-12-10 20:05:12 +00:00
// The abort(reason) method steps are to signal abort on this’s signal with reason if it is given.
m_signal->signal_abort(reason);
LibWeb: Add initial support for AbortController and AbortSignal The DOM specification says that the primary use case for these is to give Promises abort semantics. It is also a prerequisite for Fetch, as it is used to make Fetch abortable. a
2021-09-02 02:12:49 +01:00
}
}
Reference in a new issue Copy permalink