Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-19 15:43:20 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Libraries/LibWeb/SVG/SVGPathElement.cpp

44 lines
1.1 KiB
C++
Raw Normal View History

LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
/*
Userland: Use mattco@serenityos.org for my copyright headers
2021-04-22 16:53:07 -07:00
* Copyright (c) 2020, Matthew Olsson <mattco@serenityos.org>
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 01:24:48 -07:00
* SPDX-License-Identifier: BSD-2-Clause
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
*/
LibWeb: Use `Optional` for previous SVG path control point Previously, a control point at `(0, 0)` would have been considered absent. USe `Optional<Gfx::FloatPoint>` instead.
2022-12-28 22:40:40 +01:00
#include <AK/Optional.h>
LibGfx+LibWeb: Add new Path class with Skia backend, use for 2D canvas This thing is essentially a wrapper around an SkPath, although we do some indirection via a PathImpl class to keep the door open for alternative rasterizer/path backends in the future. We also update the 2D canvas code, since that was the only code that used Painter+DeprecatedPath, and this allows us to just drop that code instead of temporarily supporting it until the next commit.
2024-08-08 15:12:29 +02:00
#include <LibGfx/Path.h>
LibWeb: Remove Bindings/Forward.h from LibWeb/Forward.h This was resulting in a whole lot of rebuilding whenever a new IDL interface was added. Instead, just directly include the prototype in every C++ file which needs it. While we only really need a forward declaration in each cpp file; including the full prototype header (which itself only includes LibJS/Object.h, which is already transitively brought in by PlatformObject) - it seems like a small price to pay compared to what feels like a full rebuild of LibWeb whenever a new IDL file is added. Given all of these includes are only needed for the ::initialize method, there is probably a smart way of avoiding this problem altogether. I've considered both using some macro trickery or generating these functions somehow instead.
2024-04-27 12:09:58 +12:00
#include <LibWeb/Bindings/SVGPathElementPrototype.h>
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
#include <LibWeb/DOM/Document.h>
#include <LibWeb/DOM/Event.h>
LibWeb: Rename SVGPathBox -> SVGGeometryBox This fits better since it's now used by all SVGGeometryElements.
2022-02-11 12:37:22 +00:00
#include <LibWeb/Layout/SVGGeometryBox.h>
LibWeb: Refactor SVG files into their own directory; follow spec layout
2020-07-23 09:44:42 -07:00
#include <LibWeb/SVG/SVGPathElement.h>
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
LibWeb: Refactor SVG files into their own directory; follow spec layout
2020-07-23 09:44:42 -07:00
namespace Web::SVG {
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC_DEFINE_ALLOCATOR(SVGPathElement);
LibWeb: Put most LibWeb GC objects in type-specific heap blocks With this change, we now have ~1200 CellAllocators across both LibJS and LibWeb in a normal WebContent instance. This gives us a minimum heap size of 4.7 MiB in the scenario where we only have one cell allocated per type. Of course, in practice there will be many more of each type, so the effective overhead is quite a bit smaller than that in practice. I left a few types unconverted to this mechanism because I got tired of doing this. :^)
2023-11-19 19:47:52 +01:00
LibWeb: Move QualifiedName into the Web::DOM namespace
2022-02-18 21:00:52 +01:00
SVGPathElement::SVGPathElement(DOM::Document& document, DOM::QualifiedName qualified_name)
LibWeb: Use move semantics for QualifiedName more often
2021-02-07 11:20:15 +01:00
: SVGGeometryElement(document, move(qualified_name))
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
{
LibWeb: Move setting of Web object prototypes to initialize() This needs to happen before prototype/constructor intitialization can be made lazy. Otherwise, GC could run during the C++ constructor and try to collect the object currently being created.
2023-01-10 06:28:20 -05:00
}
LibJS: Make Cell::initialize() return void Stop worrying about tiny OOMs. Work towards #20405
2023-08-07 08:41:28 +02:00
void SVGPathElement::initialize(JS::Realm& realm)
LibWeb: Move setting of Web object prototypes to initialize() This needs to happen before prototype/constructor intitialization can be made lazy. Otherwise, GC could run during the C++ constructor and try to collect the object currently being created.
2023-01-10 06:28:20 -05:00
{
LibWeb: Avoid FlyString lookups when setting IDL interface prototypes This commit introduces a WEB_SET_PROTOTYPE_FOR_INTERFACE macro that caches the interface name in a local static FlyString. This means that we only pay for FlyString-from-literal lookup once per browser lifetime instead of every time the interface is instantiated.
2024-03-16 13:13:08 +01:00
WEB_SET_PROTOTYPE_FOR_INTERFACE(SVGPathElement);
LibWeb: Only set prototype once for object with IDL interface Before this change, we were going through the chain of base classes for each IDL interface object and having them set the prototype to their prototype. Instead of doing that, reorder things so that we set the right prototype immediately in Foo::initialize(), and then don't bother in all the base class overrides. This knocks off a ~1% profile item on Speedometer 3.
2025-04-20 16:22:57 +02:00
Base::initialize(realm);
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
}
LibWeb: Consolidate the attribute change handlers We currently have 2 virtual methods to inform DOM::Element subclasses when an attribute has changed, one of which is spec-compliant. This patch removes the non-compliant variant.
2024-11-14 08:14:16 -05:00
void SVGPathElement::attribute_changed(FlyString const& name, Optional<String> const& old_value, Optional<String> const& value, Optional<FlyString> const& namespace_)
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
{
LibWeb: Consolidate the attribute change handlers We currently have 2 virtual methods to inform DOM::Element subclasses when an attribute has changed, one of which is spec-compliant. This patch removes the non-compliant variant.
2024-11-14 08:14:16 -05:00
Base::attribute_changed(name, old_value, value, namespace_);
LibWeb: Abstract common operations of graphical SVG elements
2020-07-22 15:17:39 -07:00
LibWeb: Update SVG `get_path()` API to take a viewport size This will allow resolving paths that use sizes that are relative to the viewport. This necessarily removes the on element caching, which has been redundant for a while as computed paths are stored on the paintable.
2024-03-03 20:15:06 +00:00
if (name == "d")
LibWeb/SVG: Move path data into Path.{h,cpp} More things need this than just the `<path>` element, so let's avoid having to include `SVGPathElement.h` in places that don't need it. Minor changes at the same time: - Wrap it in a Path class - Specify underlying type for PathInstructionType - Make a couple of free functions into methods - Give PathInstruction an operator== No functionality changes.
2025-07-17 15:04:25 +01:00
m_path = AttributeParser::parse_path_data(value.value_or(String {}));
LibWeb: Factor out SVG path parsing from SVGPathElement Converting a Vector<PathInstruction> is now done by a free function so that we can share this code with HTML::Path2D. :^)
2022-11-29 14:06:41 +01:00
}
LibWeb: Port painting to use the new Skia-backed Gfx::Path SVG and and CSS border rendering now sits on top of SkPath instead of the old Gfx::DeprecatedPath. Due to an imperceptible (255, 255, 255) vs (255, 254, 255) color diff in one ref test, I changed that test to not depend on border rendering for a positive result, since that was incidental.
2024-08-09 14:00:10 +02:00
Gfx::Path SVGPathElement::get_path(CSSPixelSize)
LibWeb: Factor out SVG path parsing from SVGPathElement Converting a Vector<PathInstruction> is now done by a free function so that we can share this code with HTML::Path2D. :^)
2022-11-29 14:06:41 +01:00
{
LibWeb/SVG: Move path data into Path.{h,cpp} More things need this than just the `<path>` element, so let's avoid having to include `SVGPathElement.h` in places that don't need it. Minor changes at the same time: - Wrap it in a Path class - Specify underlying type for PathInstructionType - Make a couple of free functions into methods - Give PathInstruction an operator== No functionality changes.
2025-07-17 15:04:25 +01:00
return m_path.to_gfx_path();
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
}
}
Reference in a new issue Copy permalink