Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-11-04 07:10:57 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Libraries/LibWeb/CSS/CSSImportRule.h

64 lines
1.9 KiB
C
Raw Normal View History

LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
/*
* Copyright (c) 2021, the SerenityOS developers.
LibWeb/CSS: Don't resolve `@import` URLs until they are used The regression in the "conditional-CSSGroupingRule" test is we now fail the "inserting an `@import`" subtests differently and the subtests aren't independent. Specifically, we don't yet implement the checks in `CSSRuleList::insert_a_css_rule()` that reject certain rules from being inserted. Previously we didn't insert the `@import` rule because we failed to parse its relative URL. Now we parse it correctly, we end up inserting it.
2025-04-08 18:16:38 +01:00
* Copyright (c) 2021-2025, Sam Atkins <sam@ladybird.org>
Meta: Update my e-mail address everywhere
2024-10-04 13:19:50 +02:00
* Copyright (c) 2022, Andreas Kling <andreas@ladybird.org>
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 01:24:48 -07:00
* SPDX-License-Identifier: BSD-2-Clause
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
*/
#pragma once
#include <LibWeb/CSS/CSSRule.h>
LibWeb: Resolve cyclic dependency between StyleSheet and ImportRule Previously: CSSImportRule::loaded_style_sheet() (and others) depend on the definition of class CSSStyleSheet. Meanwhile, CSSStyleSheet::template for_each_effective_style_rule (and others) depend on the definition of class CSSImportRule. This hasn't caused any problems so far because CSSStyleSheet.h happened to be always included after CSSImportRule.h (in part due to alphabetical ordering). However, a compilation unit that (for example) only contains #include <Userland/Libraries/LibWeb/CSSImportRule.h> would fail to compile. This patch resolves this issue by pushing the inline definition of Web::CSS::CSSStyleSheet::for_each_effective_style_rule and for_first_not_loaded_import_rule into a different file, and adding the missing headers.
2021-09-30 22:57:35 +02:00
#include <LibWeb/CSS/CSSStyleSheet.h>
LibWeb/CSS: Don't resolve `@import` URLs until they are used The regression in the "conditional-CSSGroupingRule" test is we now fail the "inserting an `@import`" subtests differently and the subtests aren't independent. Specifically, we don't yet implement the checks in `CSSRuleList::insert_a_css_rule()` that reject certain rules from being inserted. Previously we didn't insert the `@import` rule because we failed to parse its relative URL. Now we parse it correctly, we end up inserting it.
2025-04-08 18:16:38 +01:00
#include <LibWeb/CSS/URL.h>
LibWeb: Make `@import` rules functional again :^) The changes in commit d462a6720afe721b6821ce14d5b7802d1890b61f meant that `CSSLoader::load_next_import_if_needed()` was no longer being called, so no `@import` rules were loading. The spec does not seem to mention when that loading should take place, but WebKit does this at parse time, as each rule is added to the style sheet. If it works for them, it's probably not that bad. :^) So, that's what we now do here. The `CSSImportRule` creates a fetch request when it is constructed, so each one is responsible for its own contents.
2021-11-18 17:34:53 +00:00
#include <LibWeb/DOM/DocumentLoadEventDelayer.h>
LibWeb: Enable EXPLICIT_SYMBOL_EXPORT
2025-07-19 19:35:33 -07:00
#include <LibWeb/Export.h>
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
namespace Web::CSS {
LibWeb: Enable EXPLICIT_SYMBOL_EXPORT
2025-07-19 19:35:33 -07:00
class WEB_API CSSImportRule final
LibWeb/CSS: Use fetch for CSS import rules This still has a few FIXMEs, but it's a ResourceLoader use gone! :^)
2024-12-20 20:25:40 +00:00
: public CSSRule {
LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated This is a monster patch that turns all EventTargets into GC-allocated PlatformObjects. Their C++ wrapper classes are removed, and the LibJS garbage collector is now responsible for their lifetimes. There's a fair amount of hacks and band-aids in this patch, and we'll have a lot of cleanup to do after this.
2022-08-28 13:42:07 +02:00
WEB_PLATFORM_OBJECT(CSSImportRule, CSSRule);
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC_DECLARE_ALLOCATOR(CSSImportRule);
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
public:
LibWeb/CSS: Don't resolve `@import` URLs until they are used The regression in the "conditional-CSSGroupingRule" test is we now fail the "inserting an `@import`" subtests differently and the subtests aren't independent. Specifically, we don't yet implement the checks in `CSSRuleList::insert_a_css_rule()` that reject certain rules from being inserted. Previously we didn't insert the `@import` rule because we failed to parse its relative URL. Now we parse it correctly, we end up inserting it.
2025-04-08 18:16:38 +01:00
[[nodiscard]] static GC::Ref<CSSImportRule> create(JS::Realm&, URL, GC::Ptr<DOM::Document>, RefPtr<Supports>, Vector<NonnullRefPtr<MediaQuery>>);
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
LibWeb: Add CSSImportRule wrapper
2022-04-22 20:22:22 +01:00
virtual ~CSSImportRule() = default;
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
LibWeb/CSS: Don't resolve `@import` URLs until they are used The regression in the "conditional-CSSGroupingRule" test is we now fail the "inserting an `@import`" subtests differently and the subtests aren't independent. Specifically, we don't yet implement the checks in `CSSRuleList::insert_a_css_rule()` that reject certain rules from being inserted. Previously we didn't insert the `@import` rule because we failed to parse its relative URL. Now we parse it correctly, we end up inserting it.
2025-04-08 18:16:38 +01:00
URL const& url() const { return m_url; }
String href() const { return m_url.url(); }
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
LibWeb: Make CSSRule and all its subclasses GC-allocated
2022-08-07 15:46:44 +02:00
CSSStyleSheet* loaded_style_sheet() { return m_style_sheet; }
CSSStyleSheet const* loaded_style_sheet() const { return m_style_sheet; }
LibWeb/CSS: Implement the `CSSImportRule.media` attribute
2025-04-02 09:39:51 +01:00
GC::Ptr<MediaList> media() const;
LibWeb: Make CSSRule and all its subclasses GC-allocated
2022-08-07 15:46:44 +02:00
CSSStyleSheet* style_sheet_for_bindings() { return m_style_sheet; }
LibWeb: Add actual document loading for the CSS (at)import rule
2021-02-21 18:44:17 +02:00
LibWeb: Implement `CSSImportRule.supportsText` Returns the supports condition specified by the given import at-rule.
2025-03-19 11:32:34 +00:00
Optional<String> supports_text() const;
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
private:
LibWeb/CSS: Don't resolve `@import` URLs until they are used The regression in the "conditional-CSSGroupingRule" test is we now fail the "inserting an `@import`" subtests differently and the subtests aren't independent. Specifically, we don't yet implement the checks in `CSSRuleList::insert_a_css_rule()` that reject certain rules from being inserted. Previously we didn't insert the `@import` rule because we failed to parse its relative URL. Now we parse it correctly, we end up inserting it.
2025-04-08 18:16:38 +01:00
CSSImportRule(JS::Realm&, URL, GC::Ptr<DOM::Document>, RefPtr<Supports>, Vector<NonnullRefPtr<MediaQuery>>);
LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated This is a monster patch that turns all EventTargets into GC-allocated PlatformObjects. Their C++ wrapper classes are removed, and the LibJS garbage collector is now responsible for their lifetimes. There's a fair amount of hacks and band-aids in this patch, and we'll have a lot of cleanup to do after this.
2022-08-28 13:42:07 +02:00
LibJS: Make Cell::initialize() return void Stop worrying about tiny OOMs. Work towards #20405
2023-08-07 08:41:28 +02:00
virtual void initialize(JS::Realm&) override;
LibWeb: Make CSSRule and all its subclasses GC-allocated
2022-08-07 15:46:44 +02:00
virtual void visit_edges(Cell::Visitor&) override;
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
LibWeb/CSS: Use fetch for CSS import rules This still has a few FIXMEs, but it's a ResourceLoader use gone! :^)
2024-12-20 20:25:40 +00:00
virtual void set_parent_style_sheet(CSSStyleSheet*) override;
LibWeb: Port CSSRule::serialized from DeprecatedString to String
2023-11-20 23:16:39 +13:00
virtual String serialized() const override;
LibWeb: Implement CSSRule and CSSStyleDeclaration serialization There are a handful of FIXME's here, but this seems generally good. Note that CSS *values* don't get serialized in a spec-compliant way since we currently rely on StyleValue::to_string() which is ad-hoc.
2021-10-01 19:57:45 +02:00
LibWeb/CSS: Use fetch for CSS import rules This still has a few FIXMEs, but it's a ResourceLoader use gone! :^)
2024-12-20 20:25:40 +00:00
void fetch();
void set_style_sheet(GC::Ref<CSSStyleSheet>);
LibWeb: Make `@import` rules functional again :^) The changes in commit d462a6720afe721b6821ce14d5b7802d1890b61f meant that `CSSLoader::load_next_import_if_needed()` was no longer being called, so no `@import` rules were loading. The spec does not seem to mention when that loading should take place, but WebKit does this at parse time, as each rule is added to the style sheet. If it works for them, it's probably not that bad. :^) So, that's what we now do here. The `CSSImportRule` creates a fetch request when it is constructed, so each one is responsible for its own contents.
2021-11-18 17:34:53 +00:00
LibWeb/CSS: Don't resolve `@import` URLs until they are used The regression in the "conditional-CSSGroupingRule" test is we now fail the "inserting an `@import`" subtests differently and the subtests aren't independent. Specifically, we don't yet implement the checks in `CSSRuleList::insert_a_css_rule()` that reject certain rules from being inserted. Previously we didn't insert the `@import` rule because we failed to parse its relative URL. Now we parse it correctly, we end up inserting it.
2025-04-08 18:16:38 +01:00
URL m_url;
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC::Ptr<DOM::Document> m_document;
LibWeb/CSS: Implement import at-rule supports conditions This indicates the features the browser must support for the given stylesheet to be fetched.
2025-03-19 11:23:33 +00:00
RefPtr<Supports> m_supports;
LibWeb/CSS: Support media queries in import at-rules
2025-04-01 14:32:11 +01:00
Vector<NonnullRefPtr<MediaQuery>> m_media_query_list;
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC::Ptr<CSSStyleSheet> m_style_sheet;
LibWeb: Make `@import` rules functional again :^) The changes in commit d462a6720afe721b6821ce14d5b7802d1890b61f meant that `CSSLoader::load_next_import_if_needed()` was no longer being called, so no `@import` rules were loading. The spec does not seem to mention when that loading should take place, but WebKit does this at parse time, as each rule is added to the style sheet. If it works for them, it's probably not that bad. :^) So, that's what we now do here. The `CSSImportRule` creates a fetch request when it is constructed, so each one is responsible for its own contents.
2021-11-18 17:34:53 +00:00
Optional<DOM::DocumentLoadEventDelayer> m_document_load_event_delayer;
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
};
LibWeb: Add fast_is<T> for CSSRule subclasses Since we already have a type enum for these, let's use it to make is<T> bypass dynamic_cast for CSS rules. These were often near the top of random browser profiles.
2021-03-18 21:50:52 +01:00
template<>
inline bool CSSRule::fast_is<CSSImportRule>() const { return type() == CSSRule::Type::Import; }
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 18:36:34 +02:00
}
Reference in a new issue Copy permalink