Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-19 23:53:20 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Libraries/LibWeb/CSS/StyleValues/IntegerStyleValue.cpp

23 lines
495 B
C++
Raw Normal View History

LibWeb: Implement IntegerStyleValue, for holding `<integer>` Having one StyleValue for `<number>` and `<integer>` is making user code more complicated than it needs to be. We know based on the property being parsed, whether it wants a `<number>` or an `<integer>`, so we can use separate StyleValue types for these.
2023-06-01 17:01:09 +01:00
/*
LibWeb/CSS: Add tokenize() method to style values, to get a list of CVs A couple of arbitrary substitution functions require us to get or produce some style value, and then substitute its ComponentValues into the original ComponentValue list. So this commit gives CSSStyleValue a tokenize() method that does so. Apart from a couple of unusual cases like the guaranteed-invalid value, style values can all be converted into ComponentValues by serializing them as a string, and then parsing that as a list of component values. That feels unnecessarily inefficient in most cases though, so I've implemented faster overrides for a lot of the basic style value classes, but left that serialize-and-reparse method as the fallback.
2025-07-10 12:17:27 +01:00
* Copyright (c) 2023-2025, Sam Atkins <sam@ladybird.org>
LibWeb: Implement IntegerStyleValue, for holding `<integer>` Having one StyleValue for `<number>` and `<integer>` is making user code more complicated than it needs to be. We know based on the property being parsed, whether it wants a `<number>` or an `<integer>`, so we can use separate StyleValue types for these.
2023-06-01 17:01:09 +01:00
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include "IntegerStyleValue.h"
LibWeb/CSS: Separate IntegerSV and NumberSV from CSSUnitValue This inheritance exists for typed-om classes, but StyleValues aren't typed-om. Somehow this makes our z-index interpolation slightly more correct. 🎉
2025-08-08 10:55:30 +01:00
#include <LibWeb/CSS/Parser/ComponentValue.h>
LibWeb: Implement IntegerStyleValue, for holding `<integer>` Having one StyleValue for `<number>` and `<integer>` is making user code more complicated than it needs to be. We know based on the property being parsed, whether it wants a `<number>` or an `<integer>`, so we can use separate StyleValue types for these.
2023-06-01 17:01:09 +01:00
namespace Web::CSS {
LibWeb: Add mode flag to CSSStyleValue::to_string() This will be used to differentiate between serialization for resolved style (i.e window.getComputedStyle()) and serialization for all other purposes.
2024-12-07 00:59:49 +01:00
String IntegerStyleValue::to_string(SerializationMode) const
LibWeb: Implement IntegerStyleValue, for holding `<integer>` Having one StyleValue for `<number>` and `<integer>` is making user code more complicated than it needs to be. We know based on the property being parsed, whether it wants a `<number>` or an `<integer>`, so we can use separate StyleValue types for these.
2023-06-01 17:01:09 +01:00
{
AK: Make String::number() infallible This API will always succeed in creating a String representing the provided number in base-10.
2024-10-14 10:05:01 +02:00
return String::number(m_value);
LibWeb: Implement IntegerStyleValue, for holding `<integer>` Having one StyleValue for `<number>` and `<integer>` is making user code more complicated than it needs to be. We know based on the property being parsed, whether it wants a `<number>` or an `<integer>`, so we can use separate StyleValue types for these.
2023-06-01 17:01:09 +01:00
}
LibWeb/CSS: Add tokenize() method to style values, to get a list of CVs A couple of arbitrary substitution functions require us to get or produce some style value, and then substitute its ComponentValues into the original ComponentValue list. So this commit gives CSSStyleValue a tokenize() method that does so. Apart from a couple of unusual cases like the guaranteed-invalid value, style values can all be converted into ComponentValues by serializing them as a string, and then parsing that as a list of component values. That feels unnecessarily inefficient in most cases though, so I've implemented faster overrides for a lot of the basic style value classes, but left that serialize-and-reparse method as the fallback.
2025-07-10 12:17:27 +01:00
Vector<Parser::ComponentValue> IntegerStyleValue::tokenize() const
{
LibWeb/CSS: Separate IntegerSV and NumberSV from CSSUnitValue This inheritance exists for typed-om classes, but StyleValues aren't typed-om. Somehow this makes our z-index interpolation slightly more correct. 🎉
2025-08-08 10:55:30 +01:00
return { Parser::Token::create_number(Number { Number::Type::Integer, static_cast<double>(m_value) }) };
LibWeb/CSS: Add tokenize() method to style values, to get a list of CVs A couple of arbitrary substitution functions require us to get or produce some style value, and then substitute its ComponentValues into the original ComponentValue list. So this commit gives CSSStyleValue a tokenize() method that does so. Apart from a couple of unusual cases like the guaranteed-invalid value, style values can all be converted into ComponentValues by serializing them as a string, and then parsing that as a list of component values. That feels unnecessarily inefficient in most cases though, so I've implemented faster overrides for a lot of the basic style value classes, but left that serialize-and-reparse method as the fallback.
2025-07-10 12:17:27 +01:00
}
LibWeb: Implement IntegerStyleValue, for holding `<integer>` Having one StyleValue for `<number>` and `<integer>` is making user code more complicated than it needs to be. We know based on the property being parsed, whether it wants a `<number>` or an `<integer>`, so we can use separate StyleValue types for these.
2023-06-01 17:01:09 +01:00
}
Reference in a new issue Copy permalink