2020-01-18 09:38:21 +01:00
|
|
|
/*
|
2020-01-24 16:45:29 +03:00
|
|
|
* Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
|
2020-01-18 09:38:21 +01:00
|
|
|
*
|
2021-04-22 01:24:48 -07:00
|
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
2020-01-18 09:38:21 +01:00
|
|
|
*/
|
|
|
|
|
2019-08-25 18:55:56 +03:00
|
|
|
#include <LibThread/Thread.h>
|
2019-11-13 21:49:24 +01:00
|
|
|
#include <pthread.h>
|
2020-12-31 00:57:44 -07:00
|
|
|
#include <string.h>
|
2019-08-25 18:55:56 +03:00
|
|
|
#include <unistd.h>
|
|
|
|
|
2019-12-07 12:49:05 -07:00
|
|
|
LibThread::Thread::Thread(Function<int()> action, StringView thread_name)
|
2020-02-02 12:34:39 +01:00
|
|
|
: Core::Object(nullptr)
|
2019-08-25 18:55:56 +03:00
|
|
|
, m_action(move(action))
|
2019-12-07 12:49:05 -07:00
|
|
|
, m_thread_name(thread_name.is_null() ? "" : thread_name)
|
2019-08-25 18:55:56 +03:00
|
|
|
{
|
LibThread: Improve semantics of Thread::join, and remove Thread::quit.
Thread::quit was created before the pthread_create_helper in pthread.cpp
that automagically calls pthread_exit from all pthreads after the user's
thread function exits. It is unused, and unecessary now.
Cleanup some logging, and make join return a Result<T, ThreadError>.
This also adds a new type, LibThread::ThreadError as an
AK::DistinctNumeric. Hopefully, this will make it possible to have a
Result<int, ThreadError> and have it compile? It also makes it clear
that the int there is an error at the call site.
By default, the T on join is void, meaning the caller doesn't care about
the return value from the thread.
As Result is a [[nodiscard]] type, also change the current caller of
join to explicitly ignore it.
Move the logging out of join as well, as it's the user's
responsibility whether to log or not.
2020-12-31 20:56:04 -07:00
|
|
|
register_property("thread_name", [&] { return JsonValue { m_thread_name }; });
|
|
|
|
register_property("tid", [&] { return JsonValue { m_tid }; });
|
2019-08-25 18:55:56 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
LibThread::Thread::~Thread()
|
|
|
|
{
|
2020-01-30 17:46:13 -06:00
|
|
|
if (m_tid) {
|
LibThread: Improve semantics of Thread::join, and remove Thread::quit.
Thread::quit was created before the pthread_create_helper in pthread.cpp
that automagically calls pthread_exit from all pthreads after the user's
thread function exits. It is unused, and unecessary now.
Cleanup some logging, and make join return a Result<T, ThreadError>.
This also adds a new type, LibThread::ThreadError as an
AK::DistinctNumeric. Hopefully, this will make it possible to have a
Result<int, ThreadError> and have it compile? It also makes it clear
that the int there is an error at the call site.
By default, the T on join is void, meaning the caller doesn't care about
the return value from the thread.
As Result is a [[nodiscard]] type, also change the current caller of
join to explicitly ignore it.
Move the logging out of join as well, as it's the user's
responsibility whether to log or not.
2020-12-31 20:56:04 -07:00
|
|
|
dbgln("Destroying thread \"{}\"({}) while it is still running!", m_thread_name, m_tid);
|
|
|
|
[[maybe_unused]] auto res = join();
|
2019-08-25 18:55:56 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void LibThread::Thread::start()
|
|
|
|
{
|
2019-11-13 21:49:24 +01:00
|
|
|
int rc = pthread_create(
|
|
|
|
&m_tid,
|
|
|
|
nullptr,
|
|
|
|
[](void* arg) -> void* {
|
|
|
|
Thread* self = static_cast<Thread*>(arg);
|
LibThread: Improve semantics of Thread::join, and remove Thread::quit.
Thread::quit was created before the pthread_create_helper in pthread.cpp
that automagically calls pthread_exit from all pthreads after the user's
thread function exits. It is unused, and unecessary now.
Cleanup some logging, and make join return a Result<T, ThreadError>.
This also adds a new type, LibThread::ThreadError as an
AK::DistinctNumeric. Hopefully, this will make it possible to have a
Result<int, ThreadError> and have it compile? It also makes it clear
that the int there is an error at the call site.
By default, the T on join is void, meaning the caller doesn't care about
the return value from the thread.
As Result is a [[nodiscard]] type, also change the current caller of
join to explicitly ignore it.
Move the logging out of join as well, as it's the user's
responsibility whether to log or not.
2020-12-31 20:56:04 -07:00
|
|
|
int exit_code = self->m_action();
|
2020-09-18 09:49:51 +02:00
|
|
|
self->m_tid = 0;
|
2019-11-13 21:49:24 +01:00
|
|
|
return (void*)exit_code;
|
|
|
|
},
|
|
|
|
static_cast<void*>(this));
|
2019-08-25 18:55:56 +03:00
|
|
|
|
2021-02-23 20:42:32 +01:00
|
|
|
VERIFY(rc == 0);
|
2019-12-07 12:49:05 -07:00
|
|
|
if (!m_thread_name.is_empty()) {
|
2020-01-11 12:54:30 +01:00
|
|
|
rc = pthread_setname_np(m_tid, m_thread_name.characters());
|
2021-02-23 20:42:32 +01:00
|
|
|
VERIFY(rc == 0);
|
2019-12-07 12:49:05 -07:00
|
|
|
}
|
LibThread: Improve semantics of Thread::join, and remove Thread::quit.
Thread::quit was created before the pthread_create_helper in pthread.cpp
that automagically calls pthread_exit from all pthreads after the user's
thread function exits. It is unused, and unecessary now.
Cleanup some logging, and make join return a Result<T, ThreadError>.
This also adds a new type, LibThread::ThreadError as an
AK::DistinctNumeric. Hopefully, this will make it possible to have a
Result<int, ThreadError> and have it compile? It also makes it clear
that the int there is an error at the call site.
By default, the T on join is void, meaning the caller doesn't care about
the return value from the thread.
As Result is a [[nodiscard]] type, also change the current caller of
join to explicitly ignore it.
Move the logging out of join as well, as it's the user's
responsibility whether to log or not.
2020-12-31 20:56:04 -07:00
|
|
|
dbgln("Started thread \"{}\", tid = {}", m_thread_name, m_tid);
|
2019-08-25 18:55:56 +03:00
|
|
|
}
|